Repository navigation
feat(mpm): support RadioLink / DumboRC special commands - #7441
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughAdds RLink MULTI support through subtype detection, Lua-driven transmission of validated RLnk payloads, and telemetry reception that delivers inbound payloads to Lua. ChangesRLink MULTI Protocol Support
Sequence Diagram(s)sequenceDiagram
participant Lua
participant setupPulsesMulti
participant MULTI
participant Telemetry
Lua->>setupPulsesMulti: provide RLnk payload
setupPulsesMulti->>MULTI: send validated payload
Telemetry->>Lua: deliver RLink telemetry payload
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@radio/src/pulses/multi.cpp`:
- Around line 485-488: The code reads Multi_Buffer[4] for bounds then re-reads
it in the loop, which can race with Lua and change length; snapshot the length
into a local variable (e.g., uint8_t count = Multi_Buffer[4]) after validating
it (1..8) and use that local variable in the for loop and index calculations
when calling sendMulti(p_buf, Multi_Buffer[5 + i]) to prevent a concurrent
change from causing an out-of-bounds access; update any related checks to
reference the snapshot variable instead of re-reading Multi_Buffer[4].
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 1f4377aa-7ca1-4281-8e5e-7a4f39ee1545
📒 Files selected for processing (4)
radio/src/pulses/modules_helpers.hradio/src/pulses/multi.cppradio/src/telemetry/multi.cppradio/src/telemetry/multi.h
ELynx
changed the title
pfeerick
changed the title
Add serial buffer for RadioLink protocol of Multimodule, to allow communication with DumboRC P Series receivers Packing, unpacking, TX, RX are handled by multimodule radio code and .lua script
|
Parent PR pascallanger/DIY-Multiprotocol-TX-Module#1164 merged, tested on same build, works! |
|
@pfeerick sorry for pinging you directly; just seeing that you linted this PR before, and there is no "default assignee" or "request review" buttons, at least ones I can see. |
|
@coderabbitai help |
ChatThere are 3 ways to chat with CodeRabbit:
CodeRabbit commands
Other keywords and placeholders
CodeRabbit configuration file (
|
|
@coderabbitai full review Since I merged some files back and forth some file ago, and also since related PR on Multimodule is merged |
|
✅ Action performedFull review finished. |
|
Multimodule was released |
|
LGTM... I don't have any specific RadioLink / DumboRC hardware to test this with, but since it is restricted to that I'm comfortable with the low blast radius given you're actually using it 🤪 |
|
screen-2026-08-23-131931.bmp |
|
Here the pics embedded from the above post for easier viewing: |
3 participants
Summary of changes:
Add serial buffer for RadioLink protocol of Multimodule, to allow communication with DumboRC P Series receivers Packing, unpacking, TX, RX are handled by multimodule radio code and .lua script.
Needed for pascallanger/DIY-Multiprotocol-TX-Module#1164
Tested changes against current main and 2.12.1 tag, both work.
Tested on my Radiomaster MT12 with Multimodule as internal module.
Summary by CodeRabbit