[ea-open-source]

Summary

--dry-run printed no server advisory. reportDryRunPlan never read plan.warnings, although a server preview returns the committing import's warnings, except one code (agile-tracker import-mapping.md §2.4.3 and §3 "Dry-run preview"). For a GitHub import, the dry run hid history_floor_clamped, dependencies_fetch_failed and dependencies_truncated at the one moment an advisory is actionable. A preview never carries cross_reference_links_failed: only a committing GitHub import takes agile-tracker's execute_github_streamed_import, which holds the PR↔issue link attach that emits it.

Story: https://eastagiletracker.com/s/ane8pe4m (#1124731)

What changed

• src/cli.js: reportDryRunPlan renders one indented note: line per plan.warnings entry through the unchanged warningLine renderer (it scrubs control characters). A missing warnings key renders nothing (?? [], as in reportImport). The direct engine shares this renderer, so its local dry run gets the same lines. src/direct.js is unchanged (sibling story #386282 fills its warnings).
• The old-server fallback (Dry run: would import ... No changes made.) is unchanged. It has no server result, so it has no warnings.
• CONTRACT.md: the warnings section says that the preview reports the committing run's advisories except cross_reference_links_failed, and where --dry-run renders them. The "cannot read as a report of a write" clause covers only a preview that the server confirmed (dry_run: true). The warning-code list is out of scope (#1124732).

Output format

Dry run plan for o/r into project 91 (Demo):
  would import 4 stories (0 labels), would skip 0, 0 error(s).
  note: history_floor_clamped (3 stories, floor year 2024)
No changes made.

The notes come after the would lines (and after any would create ... placeholder owner(s) line). No changes made. stays the last line. For a preview that the server confirmed (dry_run: true), no write took place, so an advisory cannot read as a report of a write.

Test plan

New tests (node --test):

• Server dry run with two warnings: exact plan block with both note: lines, and No changes made. as the last stdout line.
• Server dry run: a control-bearing warning code is scrubbed.
• Server dry run without warnings: the block renders and stdout has no note:.
• Direct dry run (through the runDirect seam) with a placeholder owner and two warnings: notes after the placeholder line, before the close, and close is the last line.
• Direct dry run: an ESC and a U+202E in a warning code are scrubbed.
• Direct dry run with warnings: [] and with no warnings key: no note:.
• Parity: one edge-bearing warnings list (count: 0, a floor_year without count, a bare string, a normal entry) gives equal note: lines on a committing run and on --dry-run.
• The direct engine's real dry-run and committing outcomes pin warnings to [].
• The old-server fallback prints no note:.

Red first: with the render line deleted, node --test tests/cli.test.js tests/import.test.js gives ℹ fail 4 (the four positive tests). The negative controls stay green. A second mutation renders the notes after No changes made., and both ordering tests fail (ℹ fail 2). Review-round mutations: a hand-rolled formatter in the dry-run block fails the parity test; a non-empty warnings in either direct-engine return fails its pin; a note: in the fallback fails the fallback test.

Gates on the branch:

• npm test: rc 0, ℹ tests 1287, ℹ pass 1286, ℹ fail 0, ℹ skipped 1 (the pre-existing opt-in e2e)
• npm run lint: rc 0, Found 1 warning. Found 1 info. (both pre-existing on main)
• npm run typecheck: rc 0

🤖 Generated with Claude Code