Skip to content

Skip VAR005 monotonicity check for auxiliary coordinates #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JanStreffing wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Skip VAR005 monotonicity check for auxiliary coordinates #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions plugins/cmip6/cmip6.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,15 +712,19 @@ def _sev(x, default=BaseCheck.HIGH) -> int:

# monotonicity
if getattr(rule, "monotonicity", None):
sev = _sev(rule.monotonicity.severity, default=BaseCheck.MEDIUM)
res.extend(
check_coordinate_monotonicity(
ds,
coord_name=cname,
direction=rule.monotonicity.direction,
severity=sev,
# CF allows auxiliary coordinates (e.g. lat/lon attached to a
# generic cell dimension on unstructured grids) to be non-monotonic.
# Only apply the strict-monotonicity check to dimension coords.
if cname in ds.dimensions:
sev = _sev(rule.monotonicity.severity, default=BaseCheck.MEDIUM)
res.extend(
check_coordinate_monotonicity(
ds,
coord_name=cname,
direction=rule.monotonicity.direction,
severity=sev,
)
)
)

# TIME001
if getattr(rule, "squareness", None):
Expand Down
20 changes: 12 additions & 8 deletions plugins/cmip7/cmip7.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,15 +689,19 @@ def check_Coordinates(self, ds):

# monotonicity
if rule.monotonicity:
sev = self.get_severity(rule.monotonicity.severity)
res.extend(
check_coordinate_monotonicity(
ds,
coord_name=cname,
direction=rule.monotonicity.direction,
severity=sev,
# CF allows auxiliary coordinates (e.g. lat/lon attached to a
# generic cell dimension on unstructured grids) to be non-monotonic.
# Only apply the strict-monotonicity check to dimension coords.
if cname in ds.dimensions:
sev = self.get_severity(rule.monotonicity.severity)
res.extend(
check_coordinate_monotonicity(
ds,
coord_name=cname,
direction=rule.monotonicity.direction,
severity=sev,
)
)
)

# TIME001
if rule.squareness:
Expand Down