Fix WebDAV not uploading GPS files#1044
Merged
Merged
Conversation
untitaker
force-pushed
the
webdav-upload-gps
branch
2 times, most recently
from
f035124 to
59f0543
Compare
When merging WebDAV and GPS features, we forgot to update the WebDAV feature to also upload the GPS files. WebDAV had hardcoded knowledge of which files exist and its own FileKind enum. Move the FileKind enum into QMDL store so that webdav can be agnostic over which files belong to a recording, so this is less likely to happen again. (This refactor was AI-assisted)
untitaker
force-pushed
the
webdav-upload-gps
branch
from
59f0543 to
6f46bb1
Compare
cooperq
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merging WebDAV and GPS features, we forgot to update the WebDAV
feature to also upload the GPS files.
#982 #971
WebDAV had hardcoded knowledge of which files exist and its own FileKind
enum. Move the FileKind enum into QMDL store so that webdav can be
agnostic over which files belong to a recording, so this is less likely
to happen again.
ZIP downloads were missing that file too, and that has been fixed as well.
(This refactor was AI-assisted)