Repository navigation
PHPStan level 7: correct/tighten PHPDoc types - #1641
Merged
cpeel merged 10 commits intoSep 15, 2026
Merged
Conversation
chrismiceli
approved these changes
Sep 15, 2026
cpeel
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
phpstan analyze --level 7 pinc/*.incexposed a number of cases where the PHPDocs types were either outright wrong in ways that were masked by warning level 6, or could be made more precise.These patches should all be safe to apply, as they are purely comments that guide PHPStan in CI, and don't influence any runtime checks PHP might do.