Skip to content

page_tally: Fix overly restricive type hint in f250f4c2a #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpeel merged 2 commits into from
Sep 7, 2026
Merged

page_tally: Fix overly restricive type hint in f250f4c2a #1634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ce341c
page_tally: Fix overly restricive type hint in f250f4c2a
bpfoley Sep 6, 2026
3f86327
Add smoke tests for team/member tallys for all time
bpfoley Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions SETUP/tests/smoketests/pageload_smoketest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,10 @@
{'name': 'teams-mbr-list', 'path': 'stats/members/mbr_list.php?tid=44'},
{'name': 'teams-mbr-xml', 'path': 'stats/members/mbr_xml.php?username=teststeel'},
{'name': 'teams-mdetail', 'path': 'stats/members/mdetail.php?id=1'},
{'name': 'teams-mdetail-all', 'path': 'stats/members/mdetail.php?id=1&tally_name=F1&range=all'},
{'name': 'teams-new-team', 'path': 'stats/teams/new_team.php'},
{'name': 'teams-tdetail', 'path': 'stats/teams/tdetail.php?tid=44'},
{'name': 'teams-tdetail-all', 'path': 'stats/teams/tdetail.php?tid=44&tally_name=P3&range=all'},
{'name': 'teams-teams-xml', 'path': 'stats/teams/teams_xml.php?tid=44'},
{'name': 'teams-tedit', 'path': 'stats/teams/tedit.php?tid=44'},
{'name': 'teams-tlist', 'path': 'stats/teams/tlist.php'},
Expand Down
7 changes: 5 additions & 2 deletions pinc/graph_data.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,11 @@ function user_logging_on(string $past, string $preceding): array
];
}

/** @return GraphConfig */
function tallyboard_deltas(string $tally_name, string $holder_type, int $holder_id, int $days_back): array
/**
* @param 'all'|int $days_back
* @return GraphConfig
*/
function tallyboard_deltas(string $tally_name, string $holder_type, int $holder_id, string|int $days_back): array
{
$valid_tally_names = array_keys(get_page_tally_names());

Expand Down
1 change: 1 addition & 0 deletions pinc/page_tally.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,6 +569,7 @@ function calculate_tally_sma(array $array, int $window): array
*
* In the returned array, each key is a date-string of the form "YYYY-MM-DD".
*
* @param 'all'|int $days_back
* @return array<string, int>
*/
function get_pages_per_day_for_past_n_days(string $tally_name, string $holder_type, int $holder_id, string|int $days_back): array
Expand Down