Skip to content

Fix tasks.php regression and add smoke test. #1633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpeel merged 2 commits into from
Sep 6, 2026
Merged

Fix tasks.php regression and add smoke test. #1633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74e6d4a
tasks.php: Undo excessive check on property_get_label() in c2678eeb6
bpfoley Sep 6, 2026
1ccb303
Add smoke test to exercise more of tasks.php
bpfoley Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions SETUP/tests/smoketests/pageload_smoketest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
{'name': 'base-project-3', 'path': 'project.php?id=projectID5e23a810ef693&detail_level=3'},
{'name': 'base-project-4', 'path': 'project.php?id=projectID5e23a810ef693&detail_level=4'},
{'name': 'base-tasks', 'path': 'tasks.php'},
{'name': 'base-tasks-1', 'path': 'tasks.php?task_id=2277&action=show'},
{'name': 'base-userprefs', 'path': 'userprefs.php'},
{'name': 'base-login-failure', 'path': 'accounts/login_failure.php', 'expect_status': 302},
{'name': 'base-require-login', 'path': 'accounts/require_login.php'},
Expand Down
3 changes: 3 additions & 0 deletions SETUP/tests/smoketests/test_tables.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ REPLACE INTO `user_teams` VALUES (44,'%','','http://webpage.org','wickedcoder256
/* There's no code in dproofers to INSERT into queue_defns yet. */
REPLACE INTO `queue_defns` VALUES (500,'P3',3155,1,'Esperanto','language like \'Esperanto%\' and not (genre = \'Mathematics\' and difficulty = \'hard\')',4,400,'Have Esperanto available when possible (special case artificial language: \"with\" titles more common)');

INSERT INTO `tasks` VALUES (2277,'DJVSM font fallback for DPCM2 is not ideal for missing characters',1,1,14,0,4,4,7,46,'When using DPCM2 as a proofreading font, missing characters are substituted with our fallback font: DJVSM. The fonts have different sizes, however, which means they do not line up.\r\n\r\n[original bug text follows]\r\nThe font used for the special Esperanto characters makes the special characters CAPITAL vs lower-case look very silly compared to ASCII CAPITAL vs lower-case. I think it needs a single, comprehensive font; not just patching together 2 different monospace fonts.',1586296667,110,1589924438,1,3,1589924438,1,100,'YTowOnt9');

/* The table can be created with DPage.inc project_allow_pages, and in theory
* can be populated (via intermediate text files) using project_add_page,
* and Page_modifyText, but it's clunky and annoying at the moment.
Expand Down Expand Up @@ -110,3 +112,4 @@ CREATE TABLE `projectID3141592653589` (
KEY round5_user (round5_user),
KEY state (state)
) ENGINE=MyISAM DEFAULT CHARSET=utf8mb4;

2 changes: 1 addition & 1 deletion tasks.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1757,7 +1757,7 @@ function property_get_label(string $property_id, bool $for_list_of_tasks): strin
case 'percent_complete':
return ($for_list_of_tasks ? _("Progress") : _("Percent Complete"));
}
throw new ValueError("Bad task property id: $property_id");
return '';
}

/** @param array<string, mixed> $task_a */
Expand Down