editproject.php: Refactor row formatting not to use callables & echo - #1631
Open
bpfoley wants to merge 1 commit into
Open
editproject.php: Refactor row formatting not to use callables & echo#1631bpfoley wants to merge 1 commit into
bpfoley wants to merge 1 commit into
Conversation
This allows us to put proper arguments and type hints on all the formatting functions rather than forcing them all through a common interface, and the direct calls allow PHPStan to do typechecking. It also allows us to identify and remove a dead function.
Collaborator
Author
|
There's further cleanup that could be done in the formatting functions, but one step at a time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to put proper arguments and type hints on all the formatting functions rather than forcing them all through a common interface, and the direct calls allow PHPStan to do typechecking.
It also allows us to identify and remove a dead function.