Skip to content

credits.php: Add package versions where available. - #1629

Merged
cpeel merged 1 commit into
DistributedProofreaders:masterfrom
bpfoley:credits-version
Sep 5, 2026
Merged

credits.php: Add package versions where available.#1629
cpeel merged 1 commit into
DistributedProofreaders:masterfrom
bpfoley:credits-version

Conversation

@bpfoley

@bpfoley bpfoley commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

And include versions for the pinc/3rdparty imports

Useful for figuring out what's deployed to a sandbox.

See sandbox at https://www.pgdp.org/~bfoley/c.branch/credits-version/credits.php

@cpeel

cpeel commented Sep 5, 2026

Copy link
Copy Markdown
Member

I realize it's security through obscurity, but I'm wary of advertising the version on the prod. Thoughts about limiting it just to $testing=true?

And include versions for the pinc/3rdparty imports

Useful for figuring out what's deployed to a sandbox.
@bpfoley

bpfoley commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator Author

I realize it's security through obscurity, but I'm wary of advertising the version on the prod. Thoughts about limiting it just to $testing=true?

Sure. No objections. Testing is the place it's most likely to be useful anyway: where we're trying to keep track of any number of sandboxes.

@bpfoley
bpfoley requested a review from cpeel September 5, 2026 18:18
@cpeel
cpeel merged commit 60bcef2 into DistributedProofreaders:master Sep 5, 2026
12 checks passed
@bpfoley
bpfoley deleted the credits-version branch September 5, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants