Skip to content

Add a composer validate step to CI #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpeel merged 2 commits into from
Sep 5, 2026
Merged

Add a composer validate step to CI #1628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdf68c7
composer: Unpin erusev/parsedown from exact point release version
bpfoley Sep 4, 2026
2a2316a
Add a composer validate CI step to make sure lockfiles are clean
bpfoley Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@ jobs:
php-version: '8.3'
- name: Setup Node, NPM
uses: ./.github/actions/setup-node
- name: Run lockfile checks
run: make -C SETUP/ci lockfile_checks
- name: Run security checks
run: make -C SETUP/ci security_checks
- name: Run charsuite checks
Expand Down
7 changes: 6 additions & 1 deletion SETUP/ci/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,12 @@

SELF_DIR := $(dir $(lastword $(MAKEFILE_LIST)))

all: lint code_style static_checks security_checks best_practice_checks
all: lockfile_checks lint code_style static_checks security_checks best_practice_checks

#----------------------------------------------------------------------------
# Check lockfiles are up to date
lockfile_checks:
cd $(SELF_DIR)../../ && composer validate

#----------------------------------------------------------------------------
# Security checks
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"minimum-stability": "stable",
"require": {
"ezyang/htmlpurifier" : "v4.*",
"erusev/parsedown": "1.8.0",
"erusev/parsedown": "^1.8.0",
"erusev/parsedown-extra": "0.9.0",
"voku/portable-utf8": "^6.1.1",
"phpmailer/phpmailer": "^7.0",
Expand Down
2 changes: 1 addition & 1 deletion composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.