Repository navigation
forum_interface_*: Make sure JSON & PHPBB3 have same interfaces - #1625
Merged
Merged
Conversation
After a 'Return value must be of type array, null returned' error reported by mrducky. This should in theory have been caught by pageload_smoketest.py, but unfortunately can't currently be, because the CI environment runs only with the forum_interface_json.inc code, and we'd need to set up an entire phpbb3 install to catch this in CI. In particular, make sure that all the phpb33 functions that return rows from the database have nullable return types. Fix some inconsistencies where, e.g., JSON returns 0 and PHPBB3 returns null for a non-existent user. While here, make some error handling code less verbose.
cpeel
approved these changes
Sep 4, 2026
Member
Not sure what this is referring to. Is there a missed commit or am I just overlooking something in the diff? |
Collaborator
Author
Just the use of instead of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a 'Return value must be of type array, null returned' error reported by mrducky.
This should in theory have been caught by pageload_smoketest.py, but unfortunately can't currently be, because the CI environment runs only with the forum_interface_json.inc code, and we'd need to set up an entire phpbb3 install to catch this in CI.
In particular, make sure that all the phpb33 functions that return rows from the database have nullable return types.
Fix some inconsistencies where, e.g., JSON returns 0 and PHPBB3 returns null for a non-existent user.
While here, make some error handling code less verbose.