Repository navigation
unserialize() can be passed null - #1622
Merged
Merged
Conversation
Having the function accept null for the case when a variable isn't included in a POST seems more sensible than checking the POST and passing the function an empty string.
bpfoley
approved these changes
Sep 3, 2026
| private function unserialize(string $value): mixed | ||
| private function unserialize(?string $value): mixed | ||
| { | ||
| return $value ? unserialize(base64_decode($value)) : null; |
Collaborator
There was a problem hiding this comment.
I was going to quibble about having an !is_null check here instead of truthy, but the serialization format always emits non-empty strings: "N" is null "b:0" is false etc.
https://www.phpinternalsbook.com/php5/classes_objects/serialization.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having the function accept null for the case when a variable isn't included in a POST seems more sensible than checking the POST and passing the function an empty string.
I updated TEST with the latest code, clicked around on a lot of things, and this was the only thing I found from my initial testing.