Fix autofill event downcast - ignore events of the wrong type#5379
Merged
jkelleyrtp merged 15 commits intoDioxusLabs:mainfrom Apr 7, 2026
Merged
Fix autofill event downcast - ignore events of the wrong type#5379jkelleyrtp merged 15 commits intoDioxusLabs:mainfrom
jkelleyrtp merged 15 commits intoDioxusLabs:mainfrom
Conversation
ealmloff
added
bug
ealmloff
force-pushed
the
fix-autocomplete
branch
from
32c5960 to
e09bb81
Compare
ealmloff
changed the title
Member
|
I will say, glad this fixes the bug, but I don't think the code for the html module really got any cleaner. I think we should look into using proper Rust codegen (build.rs -> html.rs) in a way that's easy to expand for other element systems like TUI / uikit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
autofill events don't show up as the right type of event. this pr adds checks for event types and ignores events we don't recognize instead of panicing
It also introduces a unified source for events and event types which deduplicates some code
Fixes #4079
Fixes #5375