Skip to content

Fixes for fast energy scans bugs#2094

Merged
Relm-Arrowny merged 3 commits into
mainfrom
1970-jaw_phase-set-does-not-set-it-to-move
Jun 30, 2026
Merged

Fixes for fast energy scans bugs#2094
Relm-Arrowny merged 3 commits into
mainfrom
1970-jaw_phase-set-does-not-set-it-to-move

Conversation

@Relm-Arrowny

@Relm-Arrowny Relm-Arrowny commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Fixes #1970 and #275

  • changed jaw phase move pv.
  • Fixed d5a_det
  • Tested on i10 idu see

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@Relm-Arrowny Relm-Arrowny linked an issue Jun 16, 2026 that may be closed by this pull request
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.16%. Comparing base (b3d163a) to head (b168979).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2094   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files         347      347           
  Lines       13585    13588    +3     
=======================================
+ Hits        13471    13474    +3     
  Misses        114      114           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Relm-Arrowny Relm-Arrowny marked this pull request as ready for review June 29, 2026 11:21
@Relm-Arrowny Relm-Arrowny requested a review from a team as a code owner June 29, 2026 11:22
@Relm-Arrowny Relm-Arrowny requested a review from a team June 29, 2026 11:22
@Relm-Arrowny Relm-Arrowny changed the title possible fix for move pv in jaw phase Fixes for fast energy scans bugs Jun 29, 2026

@Villtord Villtord left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I understand that it was tested on the beamline so all PV changes are valid.

@Relm-Arrowny Relm-Arrowny merged commit 700c0b3 into main Jun 30, 2026
11 checks passed
@Relm-Arrowny Relm-Arrowny deleted the 1970-jaw_phase-set-does-not-set-it-to-move branch June 30, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

jaw_phase set does not set it to move:

2 participants