Add command behaviour tests#60
Open
MJGaughran wants to merge 29 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## improve-golden-master-tests #60 +/- ##
================================================================
+ Coverage 83.59% 99.48% +15.89%
================================================================
Files 27 27
Lines 957 977 +20
================================================================
+ Hits 800 972 +172
+ Misses 157 5 -152 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
MJGaughran
commented
Jun 29, 2026
| DEFAULT_VERSION_FILENAME = ".version" | ||
|
|
||
| DEPLOYMENT_SNAPSHOT_FILENAME = "deployment.yaml" | ||
| PREVIOUS_DEPLOYMENT_SNAPSHOT_FILENAME = "previous-deployment.yaml" |
Contributor
Author
There was a problem hiding this comment.
Dead code (now uses git refs)
MJGaughran
commented
Jun 29, 2026
|
|
||
| It should be the Module's name and version as /<config_folder>/<name>/<version>.yaml | ||
| """ | ||
| if version_path.is_dir() and version_path.suffix == YAML_FILE_SUFFIX: |
Contributor
Author
There was a problem hiding this comment.
Dead code as _load_release() already checks if path.is_dir()
MJGaughran
force-pushed
the
add-command-behaviour-tests
branch
from
e346540 to
5730578
Compare
…tests Improve golden master tests
This covers cases that aren't easily tested with golden master tests.
Tests relating to non-existent output dir use the compare function as otherwise the Typer configuration prevents the exception being raised.
This feature was replaced with the git ref option to the compare command.
MJGaughran
force-pushed
the
add-command-behaviour-tests
branch
from
5730578 to
df673cc
Compare
MJGaughran
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These test the parts of functionality that are not adequately covered by the golden master tests, such as errors.
Code changes are added for: