Conversation
Contributor
Author
|
Rough next steps in no particular order
|
Contributor
|
tpoliaw
commented
Mar 4, 2026
tpoliaw
commented
Mar 6, 2026
tpoliaw
force-pushed
the
ws
branch
2 times, most recently
from
910d91b to
b5c01e6
Compare
tpoliaw
force-pushed
the
ws
branch
2 times, most recently
from
71bdbcf to
2371239
Compare
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1413 +/- ##
==========================================
- Coverage 95.93% 92.51% -3.43%
==========================================
Files 44 45 +1
Lines 3271 3525 +254
==========================================
+ Hits 3138 3261 +123
- Misses 133 264 +131 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Should still investigate if this is still useful but not in this change
Allows error messages to be propagated correctly.
Saves converting messages is two steps
This is trying to mask a race condition that should be handled elsewhere. If a task is started between the check and submission the task will still be started. This adds a tiledwriter to the run_engine that will receive messages from the exisiting plan and then fall over when it doesn't recognise UUIDs. It might do for now though.
_ws_address doesn't count as a get method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As an intermediate step before (or instead of?) redesigning the server sub-process handling, we can add a websocket endpoint to run the same submit-listen-start approach that the client runs remotely.