Repository navigation
refactor(ffi) move SSPI type definitions to the ffi-types - #745
Merged
Benoît Cortier (CBenoit) merged 1 commit intoSep 15, 2026
Merged
Benoît Cortier (CBenoit) merged 1 commit into
Benoît Cortier (CBenoit) merged 1 commit into
Conversation
Pavlo Myroniuk (TheBestTvarynka)
marked this pull request as ready for review
September 10, 2026 11:05
Pavlo Myroniuk (TheBestTvarynka)
requested a review
from Benoît Cortier (CBenoit)
September 10, 2026 11:05
Benoît Cortier (CBenoit)
approved these changes
Sep 15, 2026
Benoît Cortier (CBenoit)
left a comment
Benoît Cortier (CBenoit)
left a comment
Member
There was a problem hiding this comment.
Thank you! LGTM
Benoît Cortier (CBenoit)
deleted the
refactor/move-sspi-types-into-separate-crate
branch
September 15, 2026 05:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I moved all FFI-related SSPI type definitions into the
ffy-typescrate. This cleaned up the code and lets us reuse FFI-types later.Basically, I did the same as we did with WinSCard-related types back then.