Repository navigation
chore(deps): rework dependencies - #735
Merged
Merged
Conversation
Pavlo Myroniuk (TheBestTvarynka)
marked this pull request as ready for review
August 25, 2026 13:45
Pavlo Myroniuk (TheBestTvarynka)
requested a review
from Benoît Cortier (CBenoit)
August 25, 2026 15:26
Copilot started reviewing on behalf of
Benoît Cortier (CBenoit)
September 1, 2026 15:34
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Reworks third-party dependencies into crate-local declarations while retaining workspace inheritance for internal crates.
Changes:
- Moves dependency versions and features into individual manifests.
- Aligns UUID versions across standalone tools.
- Makes test integer conversions explicit.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
Cargo.toml |
Moves external dependencies out of workspace configuration. |
ffi/Cargo.toml |
Adds explicit FFI dependency specifications. |
crates/winscard/Cargo.toml |
Localizes WinSCard dependencies. |
crates/kdc/Cargo.toml |
Localizes KDC dependencies. |
crates/dpapi/Cargo.toml |
Localizes DPAPI dependencies. |
crates/dpapi-web/Cargo.toml |
Localizes web and WASM dependencies. |
crates/dpapi-transport/Cargo.toml |
Pins UUID locally. |
crates/dpapi-pdu/Cargo.toml |
Localizes PDU dependencies. |
crates/dpapi-native-transport/Cargo.toml |
Localizes runtime and transport dependencies. |
crates/dpapi-core/Cargo.toml |
Pins UUID locally. |
tools/dpapi-cli-client/Cargo.toml |
Updates UUID requirement. |
tools/wasm-testcompile/Cargo.toml |
Updates UUID requirement. |
src/credssp/ts_request/test.rs |
Uses explicit usize conversions in assertions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot started reviewing on behalf of
Benoît Cortier (CBenoit)
September 1, 2026 15:45
View session
Benoît Cortier (CBenoit)
approved these changes
Sep 1, 2026
Benoît Cortier (CBenoit)
enabled auto-merge (squash)
September 1, 2026 15:46
Member
|
Pavlo Myroniuk (@PavloMyroniuk-apriorit) Thank you! This needs rebasing before we can merge |
Pavlo Myroniuk (TheBestTvarynka)
force-pushed
the
chore/rework-dependencies
branch
from
September 1, 2026 15:52
a89d025 to
800d87d
Compare
Collaborator
Author
|
Benoît Cortier (@CBenoit) I rebased the branch |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.