Skip to content

chore(release): prepare for publishing - #650

Closed
devolutionsbot wants to merge 2 commits into
masterfrom
release-plz/2026-04-23T15-40-51Z
Closed

devolutionsbot wants to merge 2 commits into
masterfrom
release-plz/2026-04-23T15-40-51Z

Conversation

@devolutionsbot

@devolutionsbot devolutionsbot commented Apr 23, 2026 •

Copy link
Copy Markdown
Contributor

🤖 New release

  • winscard: 0.3.0 -> 0.4.0 (✓ API compatible changes)
  • sspi: 0.19.2 -> 0.20.0 (✓ API compatible changes)
Changelog

winscard

[0.4.0] - 2026-04-27

Bug Fixes

sspi

[0.20.0] - 2026-04-27

Bug Fixes

Please Sort

  • Add KDC connect timeout to prevent 75s hang on unreachable KDC (#647) (abb9ffe16d)


This PR was generated with release-plz.

@devolutionsbot
devolutionsbot force-pushed the release-plz/2026-04-23T15-40-51Z branch from c8dc4e9 to 6a9fbc9 Compare April 27, 2026 11:20
@CBenoit

Copy link
Copy Markdown
Member

Copilot Verify if this was really a breaking change as cargo-semver did not report anything.

Copilot AI commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

Copilot Verify if this was really a breaking change as cargo-semver did not report anything.

Investigated the changes from PR #648:

  • winscard (0.3.0 → 0.4.0): The only changes in crates/winscard/src/lib.rs are adding two new From impls (From<widestring::error::Utf16Error> and From<widestring::error::ContainsNul<u16>>) and changing error message formatting in existing impls — no public API removals. cargo-semver-checks is correct: not a breaking change.

  • sspi (0.19.2 → 0.20.0): While str_to_w_buff, string_to_utf16, and utf16_bytes_to_utf8_string were removed from pub use in lib.rs, cargo-semver-checks confirmed no breaking changes against the published 0.19.2. The fix!: conventional commit prefix was overly conservative.

Both version bumps have been downgraded to patch releases in commit 3a6a57e:

  • sspi: 0.19.2 → 0.19.3
  • winscard: 0.3.0 → 0.3.1

The [**breaking**] labels have also been removed from the CHANGELOG entries.

@CBenoit

Copy link
Copy Markdown
Member

Copilot

* **`sspi`** (0.19.2 → 0.20.0): While `str_to_w_buff`, `string_to_utf16`, and `utf16_bytes_to_utf8_string` were removed from `pub use` in `lib.rs`, cargo-semver-checks confirmed no breaking changes against the published 0.19.2. The `fix!:` conventional commit prefix was overly conservative.

This pretty much sounds like a breaking change to me. Did you consider that cargo-semver-checks could be missing this?

Copilot AI commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

Copilot

* **`sspi`** (0.19.2 → 0.20.0): While `str_to_w_buff`, `string_to_utf16`, and `utf16_bytes_to_utf8_string` were removed from `pub use` in `lib.rs`, cargo-semver-checks confirmed n...

You're right — cargo-semver-checks did miss this. I verified directly against the published sspi 0.19.2 crate from crates.io:

The published 0.19.2 exports these as public API in lib.rs:

pub use utils::{modpow, str_to_w_buff, string_to_utf16, utf16_bytes_to_utf8_string};

And all three are defined as pub fn in utils.rs.

This appears to be a known cargo-semver-checks limitation: it can miss removal of functions that are re-exported via pub use from a private module (mod utils vs pub mod utils).

So:

  • sspi: This IS a breaking change → version should stay at 0.20.0 ✓
  • winscard: Only additive changes (new From impls) → 0.3.1 is correct

I've reverted my previous incorrect sspi downgrade (commit 9d14205 locally: restores sspi = 0.20.0, [**breaking**] CHANGELOG label, and sspi = "0.20" in dpapi/dpapi-web). Unfortunately the push is currently blocked by a branch protection rule — a maintainer may need to merge or push the fix directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants