fix(ffi): borrow program_name in AuthenticodeSignature::new - #537
Open
irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 1 commit into
Open
irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 1 commit into
irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 1 commit into
Conversation
The bridge took `Option<Box<RsString>>`, so Rust freed the string at the end of the call while the C# `RsString` still owned the same pointer and freed it again on dispose/finalize. Take a reference instead. The generated C# doesn't change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
irvingouj@Devolutions (irvingoujAtDevolution)
added this pull request to stack #540
September 29, 2026 18:56
irvingouj@Devolutions (irvingoujAtDevolution)
marked this pull request as ready for review
September 29, 2026 19:24
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AuthenticodeSignature::newtookprogram_nameasOption<Box<RsString>>. Rust freed the string at the end of the call, but the C#RsStringstill owned the pointer and freed it again on dispose/finalize. Now it just borrows. The generated C# is the same either way, so it's a one-line change.Bottom of the Diplomat devo.2 stack, see #536.
Tested: clippy clean,
Devolutions.Picky.Tests26/26 locally.