Repository navigation
fix(server)!: pass a GfxContext to the GfxServerFactory build methods - #2104
Draft
uchouT (uchouT) wants to merge 4 commits into
Draft
uchouT (uchouT) wants to merge 4 commits into
uchouT (uchouT) wants to merge 4 commits into
Conversation
The display suppression flag and the auto-detect handles describe one connection, but were created with the server and reset by hand at the start of each connection. Each connection now creates its own and hands them to the display backend through `updates()`, which is called again with the same handles after a Deactivation-Reactivation Sequence. BREAKING CHANGE: `RdpServerDisplay::updates` takes a `DisplayContext`. `RdpServer::display_suppressed_handle`, `autodetect_rtt_handle`, `autodetect_baseline_rtt_handle`, `autodetect_bandwidth_handle`, `autodetect_bandwidth_generation_handle` and the matching `RdpServerBuilder::with_*_handle` methods are removed; read the handles from the `DisplayContext` instead. Signed-off-by: uchouT <i@uchout.moe>
Signed-off-by: uchouT <i@uchout.moe>
Signed-off-by: uchouT <i@uchout.moe>
The EGFX backend needs the connection's auto-detect handles for flow control, but could only get them sideways through the display. Channel backends are now built once the connection has authenticated, together with its state, so the build methods can be handed the same handles the display gets. The connection's EGFX server reaches the display through `DisplayContext`. BREAKING CHANGE: `GfxServerFactory::build_gfx_handler` and `build_server_with_handle` take a `GfxContext`. `RdpServer::gfx_handle` is removed; use `DisplayContext::gfx_handle` instead. Channel factories are no longer invoked for a connection that ends before negotiation and authentication complete. Signed-off-by: uchouT <i@uchout.moe>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2073, stack on it.
Initial discussion: #2073 (comment)
Channel backends are now built in
finalize_negotiated, once a connection has authenticated, together with itsConnectionState.GfxServerFactory's build methods take aGfxContextcarrying the same auto-detect handles the display gets, and the connection's EGFX server reaches the display throughDisplayContext::gfx_handle, replacingRdpServer::gfx_handle().Breaking: the
GfxServerFactorysignatures change,RdpServer::gfx_handle()is removed, and factories are no longer invoked for a connection that ends before negotiation and authentication complete.