You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds the KdcResolution enum, which specifies how Kerberos should resolve the KDC, either by using IAKERB proxy or by connecting directly to an external KDC specified by URL.
THis PR is part of integration of the IAKERB extension in sspi-rs and updates the codebase to use the updated public API of sspi-rs.
github-actionsBot
added
needs-review
A human reviewer is the current next actor
risk/unknown
Risk could not be determined automatically; needs maintainer-level scrutiny
scope/core
Touches the core architectural tier
scope/ffi
Affects native or .NET bindings
scope/web
Affects the web/WASM ecosystem
size/L
Size: up to 899 counted lines and 20 files; exceeds M in either measure
labels
Sep 24, 2026
Clear stale kdcproxyname when mirroring explicit Kerberos config
crates/ironrdp-client/src/config.rs:1347
When cfg selects IAKerb, an existing kdcproxyname loaded from the property set survives because only kdcproxyurl is cleared. The built config uses IAKERB, but its public properties() still advertises the old proxy; feeding those properties into another builder then selects KdcUrl instead. Clear kdcproxyname whenever an explicit Kerberos config is mirrored so the two representations cannot conflict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needs-author-actionThe pull request author is the current next actorrisk/unknownRisk could not be determined automatically; needs maintainer-level scrutinyscope/coreTouches the core architectural tierscope/ffiAffects native or .NET bindingsscope/webAffects the web/WASM ecosystemsize/LSize: up to 899 counted lines and 20 files; exceeds M in either measure
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
KdcResolutionenum, which specifies how Kerberos should resolve the KDC, either by using IAKERB proxy or by connecting directly to an external KDC specified by URL.THis PR is part of integration of the IAKERB extension in
sspi-rsand updates the codebase to use the updated public API ofsspi-rs.Related PRs