perf(api): index the module join tables#366
Conversation
module_issues, module_members and module_links had no indexes, so every lookup by module_id or issue_id was a sequential scan, while the cycle join tables already have the equivalent indexes. Add them in migration 000014. This covers the index half of Devlaner#346. The N+1 association loading it also mentions is a larger refactor and is left for a follow-up. Refs Devlaner#346 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 50 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
The module join tables (
module_issues,module_members,module_links) had no indexes, so every lookup bymodule_idorissue_idwas a sequential scan. The cycle join tables already have the equivalent indexes.Linked issues
Refs #346 (the index half)
Type of change
perf:)Surface
apps/api/)apps/api/migrations/)What changed
Migration
000014addsidx_module_issues_module,idx_module_issues_issue,idx_module_members_moduleandidx_module_links_module, usingCREATE INDEX IF NOT EXISTSso it's safe to re-run.Scope note
Issue #346 also flags N+1 association loading in the issue list/detail paths. That's a larger refactor (batching assignees/labels/cycles/modules), so I've left it for a separate PR and kept this one to the indexes.
Migration ordering
I have another open PR (#350) that adds
000013. This one is000014, so it should merge after #350 to keep the sequence clean. Happy to renumber if you'd prefer.Test plan
go build,go vet,go test ./...green; migration applies as plainCREATE INDEX IF NOT EXISTSAI assistance
Claude Code (Opus 4.8), commits carry aCo-Authored-By:trailer