Add filter is:tieredweapon - #11945
Open
Taskeren wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Added
is:tieredweaponfilter to list weapons with tiers.Weapons in Collection can't be filtered with
tier:filter because they're all considered as tier 0.This PR adds a filter to correctly filter the weapons with tiers, both normal tiered weapons (weapons with "Tier N Upgrade" socket specifically) and craftable legendary weapons.
This is my first PR to DIM, so I'm not sure if I'm doing things correctly. The contribution markdown says I need to run
pnpm fixto fit the style, but the it's making a huge modification to the whole project, so I reverted it.