Skip to content

docs: comment instructions for PR template#1710

Merged
rstijerina merged 5 commits into
mainfrom
docs/pr-template-comments
Jun 2, 2026
Merged

docs: comment instructions for PR template#1710
rstijerina merged 5 commits into
mainfrom
docs/pr-template-comments

Conversation

@wesleyboar

@wesleyboar wesleyboar commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Overview:

Updated the pull request template to include comment descriptions for each section.

Note

💡 Consider deleting "Summary of Changes" (seems redundant given "Overview").

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

  • added comments to .github/pull_request_template.md

Testing Steps:

  1. Verify comments are not rendered:
    https://github.com/DesignSafe-CI/portal/blob/docs/pr-template-comments/.github/pull_request_template.md

UI Photos:

See raw content or just the diff.

Notes:

I've added different PR template comments in TACC/Core-CMS and TACC/Core-Styles. This PR adds comments that respect what I have seen in DesignSafe PRs.

Updated the pull request template to include comment descriptions for each section.
Clarify the purpose of the summary section in the pull request template.
@wesleyboar wesleyboar marked this pull request as ready for review June 1, 2026 20:41
@wesleyboar wesleyboar requested review from fnets, nathanfranklin, nessasmithhh and rstijerina and removed request for rstijerina June 1, 2026 20:44

@fnets fnets left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be helpful! Although, I guess we could make the argument that if the template is complicated enough that we need comments, we might want to simplify the template.

Ending heading with hashes is redundant. Heading text needs no colon; colon is for content text that introduces more content.
@wesleyboar

wesleyboar commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator Author

Updates:

@rstijerina rstijerina merged commit 23b9d6d into main Jun 2, 2026
5 checks passed
@rstijerina rstijerina deleted the docs/pr-template-comments branch June 2, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants