Feat/wp 709 react dashboard#1707
Open
nessasmithhh wants to merge 5 commits into
Open
Conversation
nessasmithhh
changed the base branch from
feat/react-dashboard
to
feat/new-dashboard
Collaborator
|
PR description looks incomplete and malformed. Is an edit underway? |
Author
Is there a certain area that looks incomplete? Everything is rendering correctly on my end. |
Contributor
The line on "summary of changes" was all one line, rather than a header and a body. I went ahead and fixed it (just added a linebreak) |
edmondsgarrett
left a comment
edmondsgarrett
left a comment
Contributor
There was a problem hiding this comment.
One of these videos has a broken link, I'd recommend checking in on if its been moved/removed/etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
Replaced some content, refactored layout, and fixed video ID.
PR Status:
Related Jira tickets:
Summary of Changes:
Replaced "Checking Allocation Balance" with two new videos: "Overview Of The Dashboard" & "How To Marek Favorite Apps"
Refactored the layout from a 2-video grid + single card to a unified 2x2 grid
Fixed the incorrect Youtube video ID for "How To Mark Favorite Apps"
Testing Steps:
Click each of the 4 video thumbnails and confirm they open to the correct youtube videos
Verify all 4 thumbnails render correctly with no broken images
Verify the 2x2 grid layout renderws correctly on the dashboard
UI Photos:
Notes: