add a command for managing orphan images - #2794
Draft
chris48s wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs https://app.asana.com/1/1204880536137786/project/1204880927741389/task/1216711410006498?focus=true
#2793
addresses the problem moving forwards, but we also have some cleanup to do.
Over the years, we have deleted various PersonImage objects without cleaning up the corresponding files on S3.
In this PR I have added a command that lets us list (and optionally delete) files on S3 with no corresponding
PersonImagerecord.Having run a list I'm a bit worried about how many orphans it wants to delete. I've checked that I am not picking up images related to QueuedImage, FacebookAdvert, PartyEmblem, or AWSTextractParsedSOPNImage models. That's not it.
I think this one might be a good one to discuss next surgery.