Shuffle the open duplicate-suggestion list - #2754
Open
c-tonneslan wants to merge 1 commit into
Open
Conversation
The complex duplicate suggestions tend to pile up at the top, which
makes it hard for reviewers to find the quick wins. order_by('?')
gets the easier ones into rotation.
Closes DemocracyClub#2724
Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2724.
@russss flagged that the complex suggestions pile up at the top of the open-suggestion list, so reviewers have to page through the difficult ones before they find a quick win. Adds
order_by('?')to the listview queryset so the order rotates.