Sweep up stale wikipedia_bio rows in the daily import - #2395
Open
c-tonneslan wants to merge 1 commit into
Open
Conversation
Person.save already clears wikipedia_bio when wikipedia_url is blank, but rows that haven't been resynced since the URL was removed on YNR still have the old extract sitting in the database. Have the daily import_wikipedia_bios command sweep them up at the end. Refs DemocracyClub#2319 Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2319.
Person.saveclearswikipedia_biowhenwikipedia_urlis blank (added in #2347), so going forward a sync that drops the URL also drops the bio. But anything that hasn't been re-saved since that fix landed still has the old extract in the database, which is what @GeoWill flagged on the issue.Tacked a small
Person.objects.filter(...).update(wikipedia_bio=None)onto the end ofupdate_peopleinimport_wikipedia_biosso the daily Lambda picks them up on its next run.