Fix retention permission error - #1496
Open
not-sekiun wants to merge 3 commits into
Open
Conversation
…ntion deletion and added tests
…or python 3.5 os.utime function signature
not-sekiun
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #1495 I made the changes to catch and swallow PermissionError + added some tests to test that PermissionErrors do not propagate unhandled. Since logfile deletion is more a best case rather than hard guarantee thing I figured it would be more idiomatic to simply catch and pass.
The catch is a bit broad though since if it triggers on nix systems it also gets swallowed vs on Windows where the PermissionError might be a bit more common, i dont know your preference so just let me know what changes youd like to handle that case