Fix/magazine

[yxpjseo]

📌 관련 이슈

• close #00

🔎 What is this PR?

매거진 상세 조회 응답과 장소 북마크 저장 간의 식별자 네이밍을 magazineId 로 정리했습니다.
또한 북마크 목록 응답에서 매거진 연동(magazineId 반환)이 누락되어 있던 부분을 함께 구현했습니다.

✨ Changes

• 매거진 상세 응답에서 magazineId 로 식별자 일원화
  • 이전 PR에서 GetMagazineDetail 응답의 식별자를 placeId 하나로 정리했으나, placeId 라는 이름이 내부 Place PK로 오해될 소지가 있었습니다.
  • 값의 실체는 관광공사 contentId이므로, 이름을 magazineId 로 변경해 의미를 명확히 했습니다.
  • MagazineConverter.toDetail 에서 빌더를 .placeId(...) → .magazineId(...) 로 수정.
  • 저장(POST /places/bookmarks) 시 이 magazineId 를 contentId 로 넘기면 됩니다.
• 북마크 목록 조회 응답 (BookmarkPlaceConverter)
  • 항상 null 이던 magazineId 를 실제 값으로 채움
  • 관광(KorService2) 출처 장소는 tour_content_id 를 magazineId(=contentId) 로 반환
  • 네이버 출처 장소는 값이 없어 null (매거진 상세 이동 불가)
  • tour_content_id → Long 변환 헬퍼(parseContentId) 추가, 값이 없거나 숫자가 아니면 null 처리
• API 문서 보강
  • PlaceController 매거진 장소 저장 API, PlaceReqDTO.CreateBookmark.contentId 에 설명 추가
  • contentId = 매거진 상세 응답의 magazineId 값(관광 KorService2 콘텐츠 ID, 내부 Place PK 아님)

📷 Result

💬 To. Reviewer

프론트 영향은 아래 두 가지입니다.

• 매거진 상세 응답에서 placeId → magazineId 로 파싱 필드명만 변경
• 북마크 저장 시 contentId 값으로 상세 응답의 magazineId 를 그대로 전달

네이버 출처 장소의 magazineId = null 처리는 기획 확인 후 변경될 수 있습니다.(논의 완)

✅ 체크 리스트

• base 브랜치(develop 또는 main) 최신 상태 pull 및 충돌 확인 완료
• Reviewers 설정
• Assignees 설정
• Labels 설정

Summary by CodeRabbit

• Improvements
  • Updated magazine detail responses to expose the tourism content identifier as magazineId.
  • Improved bookmark creation so the corresponding tourism content ID is saved correctly.
• Documentation
  • Clarified API documentation for bookmark requests, including how magazineId maps to contentId.
  • Added guidance distinguishing the tourism content ID from the internal place identifier.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6f8ad73b-b9ce-48a3-9eaf-2342ed3238b5

📥 Commits

Reviewing files that changed from the base of the PR and between da89a4c and 42b1957.

📒 Files selected for processing (5)

• src/main/java/com/daytodo/domain/place/controller/PlaceController.java
• src/main/java/com/daytodo/domain/place/converter/BookmarkPlaceConverter.java
• src/main/java/com/daytodo/domain/place/converter/MagazineConverter.java
• src/main/java/com/daytodo/domain/place/dto/request/PlaceReqDTO.java
• src/main/java/com/daytodo/domain/place/dto/response/MagazineResDTO.java

---

📝 Walkthrough

Walkthrough

The change aligns magazine detail responses and bookmark requests around the tourism content ID. Bookmark conversion now parses tourContentId, and API documentation clarifies the identifier mapping.

Changes

Magazine bookmark identifier flow

Layer / File(s)	Summary
Expose the tourism content ID src/main/java/com/daytodo/domain/place/dto/response/MagazineResDTO.java, src/main/java/com/daytodo/domain/place/converter/MagazineConverter.java	The magazine detail response now exposes magazineId and populates it from the source content ID.
Map and document bookmark content IDs src/main/java/com/daytodo/domain/place/converter/BookmarkPlaceConverter.java, src/main/java/com/daytodo/domain/place/dto/request/PlaceReqDTO.java, src/main/java/com/daytodo/domain/place/controller/PlaceController.java	Bookmark conversion parses numeric tourContentId values into magazineId. API descriptions document that contentId uses the tourism content ID, not the internal Place primary key.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• DayTodo/DayTodo_BE#23: Introduced the bookmark response and endpoint flow updated by this change.
• DayTodo/DayTodo_BE#43: Introduced the magazine ID and content ID mapping refined here.
• DayTodo/DayTodo_BE#66: Also changed the magazine detail identifier to the tourism content ID.

Suggested reviewers: kwonwnsduf

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title relates to the magazine identifier fix but is too vague to describe the primary changes clearly.	Use a specific title such as "Fix magazine ID handling in detail and bookmark APIs".

✅ Passed checks (4 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/magazine

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[hyeoniss]

수고하셨습니다!!