Repository navigation
이메일 인증 메일 링크 및 인증 결과 화면 수정 - #65
Conversation
|
Warning Review limit reached
Next review available in: 55 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe email service now sends a configured verification link. The verification endpoint returns HTML success or failure pages and maps token errors to HTTP 400 responses. The application configuration adds ChangesEmail verification flow
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/main/resources/application.yml`:
- Line 80: Restore the YAML property key on the affected line so it is exactly
course-reminder-cron with the existing ${COURSE_REMINDER_CRON:0 0 9 * * *}
value, removing the accidental git command text. Preserve the notification
configuration structure so consumers can resolve
notification.course-reminder-cron.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: d459aea2-6997-46a9-94b3-882e7885c256
📒 Files selected for processing (3)
src/main/java/com/daytodo/domain/auth/controller/AuthController.javasrc/main/java/com/daytodo/domain/auth/service/AuthMailService.javasrc/main/resources/application.yml
📌 관련 이슈
🔎 What is this PR?
회원가입 시 발송되는 이메일 인증 메일의 안내 문구 및 인증 링크 클릭 시 결과 화면을 개선합니다.
✨ Changes
AuthMailService.sendVerificationEmailGET /auth/verify-email?token=...형태의 API 명세 표기와 원시 토큰 값을 메일 본문에 그대로 노출app.base-url설정값을 조합해 실제 클릭 가능한 전체 URL(https://dev.daytodo.cloud/auth/verify-email?token=...)로 안내하도록 수정application.ymlapp.base-url프로퍼티 추가 (APP_BASE_URL환경변수, 기본값 dev 도메인)AuthController.verifyEmailAuthResponse.EmailVerifiedJSON을 그대로 반환해, 메일 링크 클릭 시 브라우저에 JSON이 노출됨INVALID_VERIFICATION_TOKEN,EXPIRED_VERIFICATION_TOKEN등 에러 케이스별 문구 분기 처리)AuthService.verifyEmail을 비롯한 서비스 로직은 변경 없음📷 Result
💬 To. Reviewer
verifyEmail엔드포인트만 예외적으로 JSON이 아닌 HTML을 반환하도록 바꿨는데, 이 방식이 괜찮은지 확인 부탁드려요.✅ 체크 리스트
Summary by CodeRabbit
New Features
Configuration