[pipeline-test] High-risk visual break (expect hold gate)#77
Open
MengpingZhang wants to merge 1 commit into
Open
[pipeline-test] High-risk visual break (expect hold gate)#77MengpingZhang wants to merge 1 commit into
MengpingZhang wants to merge 1 commit into
Conversation
|
🐝 Hi @MengpingZhang! I'm Trusted users — org members and contributors with write access — can mention Automation may take a moment to start, and follow-up happens through workflow activity rather than chat replies. |
|
👋 Hey @MengpingZhang — thanks for opening this PR!
This is an automated message. |
Replaces the global navbar change with a settings-only visible change (bg-pink-600 on settings-page container) so this PR's failing-spec set (settings specs only) differs from the navbar PR's set (all specs), producing a distinct failure signature. Keeps the no-op comment in web/src/lib/api.ts to exercise the high-risk file gate. Co-authored-by: Cursor <cursoragent@cursor.com>
MengpingZhang
force-pushed
the
test/visual-highrisk-break
branch
from
b6c911e to
7db1bad
Compare
Visual diff evidence packaged for issue agentOutcome:
|
Visual diff evidence packaged for issue agentOutcome:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipeline test: PR B (high-risk visual break)
Two changes:
bg-pink-600on thesettings-pagecontainer inweb/src/components/settings/Settings.tsx). This breaks ONLY the/settingsbaselines (app-settings-desktop-1440.png,app-settings-fullpage-1440.png), so this PR's failing-spec SET differs from PR A's global-navbar break (which fails every baselined route). Distinct failing-spec set => distinct failure signature, so A and B do NOT dedup onto one shared issue.web/src/lib/api.ts, which matchesissue_agent.high_risk_globs, soisHighRiskbecomes true.Expected validation outcome
test/visual-highrisk-break) is auto-created carryinghold+needs-triage(the human gate).Do not merge. CI takes several minutes; observe checks + the auto-created issue afterward.
Made with Cursor