Skip to content

fix(cdc): normalize zero length varchar metadata #4558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hutiefang76 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(cdc): normalize zero length varchar metadata #4558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion dinky-cdc/dinky-cdc-core/src/main/java/org/dinky/cdc/convert/DataTypeConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,17 @@ public static LogicalType getLogicalType(Column column) {
return new VarBinaryType(Integer.MAX_VALUE);
case STRING:
default:
return new VarCharType(Asserts.isNull(column.getLength()) ? Integer.MAX_VALUE : column.getLength());
return new VarCharType(normalizeVarCharLength(column.getLength()));
}
}

private static int normalizeVarCharLength(Integer length) {
if (Asserts.isNull(length) || length < VarCharType.MIN_LENGTH) {
return VarCharType.MAX_LENGTH;
}
return length;
}

public static Object convertToRow(Object value, LogicalType logicalType, ZoneId timeZone) {
if (Asserts.isNull(value)) {
return null;
Expand Down
22 changes: 22 additions & 0 deletions dinky-cdc/dinky-cdc-core/src/test/java/org/dinky/cdc/convert/DataTypeConverterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,36 @@

package org.dinky.cdc.convert;

import org.dinky.data.model.Column;
import org.dinky.data.types.DataTypes;

import org.apache.flink.table.types.logical.LogicalType;
import org.apache.flink.table.types.logical.TimestampType;
import org.apache.flink.table.types.logical.VarCharType;

import java.time.ZoneId;

import org.junit.Assert;
import org.junit.Test;

public class DataTypeConverterTest {

@Test
public void testGetLogicalTypeWithZeroLengthString() {
Column column = Column.builder()
.name("enum_column")
.type("VARCHAR")
.isNullable(true)
.length(0)
.dataType(DataTypes.VARCHAR.toColumnType(true, 0))
.build();

LogicalType logicalType = DataTypeConverter.getLogicalType(column);

Assert.assertTrue(logicalType instanceof VarCharType);
Assert.assertEquals(VarCharType.MAX_LENGTH, ((VarCharType) logicalType).getLength());
}

// todo: check the time zone of Timestamp
// @Test
public void testConvertToRowWithTimestamp() {
Expand Down
Loading