Skip to content

upsc: Correct two metric names in metadata.csv - #3139

Open
pault-pg wants to merge 1 commit into
DataDog:masterfrom
pault-pg:upsc-metadata-metric-names
Open

upsc: Correct two metric names in metadata.csv#3139
pault-pg wants to merge 1 commit into
DataDog:masterfrom
pault-pg:upsc-metadata-metric-names

Conversation

@pault-pg

Copy link
Copy Markdown
Contributor

What does this PR do?

Corrects two metric names in upsc/metadata.csv. The check reports upsc. followed by the NUT variable name, and the NUT variables are ups.status and ups.load, so the metrics are upsc.ups.status and upsc.ups.load. metadata.csv listed them as upsc.status and upsc.load.

Motivation

Those two metrics are emitted under different names than metadata.csv documents, so the units and descriptions there do not reach them.

Verified on a host running the integration:

datadog-agent check upsc | grep '"metric"' | sort -u

which lists upsc.ups.status and upsc.ups.load.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If this PR includes a log pipeline, please add a description describing the remappers and processors.

Additional Notes

Metadata only, with no change to the data the check reports, so there is no version bump or changelog entry, matching #2864. The no-changelog label is probably needed. No tests, since nothing executable changed.

LLM assistance was used to compare the emitted metric names against metadata.csv and to write this description.

@pault-pg
pault-pg requested review from a team and platinummonkey as code owners August 27, 2026 02:40
@pault-pg

Copy link
Copy Markdown
Contributor Author

The two failing checks are one cause, and it looks pre-existing rather than something this PR introduced.

test / check is the alls-green aggregate, so it fails because the other one did. The real failure is test-minimum-base-package, which installs the oldest base package this integration declares:

dependencies = ["datadog-checks-base>=4.2.0"]

That version cannot be imported on Python 3.13. Reproducible with nothing from this PR involved:

$ uv venv --python 3.13 /tmp/minbase
$ uv pip install --python /tmp/minbase/bin/python 'datadog-checks-base==4.2.0'
$ /tmp/minbase/bin/python -c "import datadog_checks.base"
ModuleNotFoundError: No module named 'checks'
...
ModuleNotFoundError: No module named 'six'

which is the same chain CI reports while collecting tests/test_upsc.py. The regular test job passes, only the minimum-version variant fails, and this PR only edits metadata.csv.

>=4.2.0 is declared by 17 integrations in this repository, against 26 on >=37.20.0, so upsc is not unusual here. The job only runs for an integration when that integration is touched, which is presumably why it does not come up more often.

I am happy to raise the floor for upsc in a separate PR if that would help, but which version to pick looks like a support-policy decision rather than simply the oldest one that imports, so I would rather you name it than guess.

LLM assistance was used to isolate the failing job and to write this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants