upsc: Correct two metric names in metadata.csv - #3139
Conversation
|
The two failing checks are one cause, and it looks pre-existing rather than something this PR introduced.
dependencies = ["datadog-checks-base>=4.2.0"]That version cannot be imported on Python 3.13. Reproducible with nothing from this PR involved: $ uv venv --python 3.13 /tmp/minbase
$ uv pip install --python /tmp/minbase/bin/python 'datadog-checks-base==4.2.0'
$ /tmp/minbase/bin/python -c "import datadog_checks.base"
ModuleNotFoundError: No module named 'checks'
...
ModuleNotFoundError: No module named 'six'which is the same chain CI reports while collecting
I am happy to raise the floor for upsc in a separate PR if that would help, but which version to pick looks like a support-policy decision rather than simply the oldest one that imports, so I would rather you name it than guess. LLM assistance was used to isolate the failing job and to write this comment. |
What does this PR do?
Corrects two metric names in
upsc/metadata.csv. The check reportsupsc.followed by the NUT variable name, and the NUT variables areups.statusandups.load, so the metrics areupsc.ups.statusandupsc.ups.load.metadata.csvlisted them asupsc.statusandupsc.load.Motivation
Those two metrics are emitted under different names than
metadata.csvdocuments, so the units and descriptions there do not reach them.Verified on a host running the integration:
which lists
upsc.ups.statusandupsc.ups.load.Review checklist
no-changeloglabel attachedAdditional Notes
Metadata only, with no change to the data the check reports, so there is no version bump or changelog entry, matching #2864. The
no-changeloglabel is probably needed. No tests, since nothing executable changed.LLM assistance was used to compare the emitted metric names against
metadata.csvand to write this description.