Skip to content

Rename get_default_config to get_default_metrics in redis_cloud/redis_enterprise checks #3128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
philjlee wants to merge 1 commit into from
Closed

Rename get_default_config to get_default_metrics in redis_cloud/redis_enterprise checks #3128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions redis_cloud/datadog_checks/redis_cloud/check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def __init__(self, name, init_config, instances):
def _parse_config(self):
self.scraper_configs = []
metrics_endpoint = self.instance.get('openmetrics_endpoint')
metrics = self.get_default_config()
metrics = self.get_default_metrics()

additional = []
groups = self.instance.get('extra_metrics', [])
Expand Down Expand Up @@ -49,7 +49,7 @@ def _parse_config(self):
config.update(self.instance)
self.scraper_configs.append(config)

def get_default_config(self):
def get_default_metrics(self):
metrics = []
for dm in DEFAULT_METRICS:
metrics.append(dm)
Expand Down
4 changes: 2 additions & 2 deletions redis_enterprise/datadog_checks/redis_enterprise/check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def _parse_config(self):
self.scraper_configs = []
metrics_endpoint = self.instance.get('openmetrics_endpoint')
self.instance.setdefault("tls_verify", True)
metrics = self.get_default_config()
metrics = self.get_default_metrics()

additional = []
groups = self.instance.get('extra_metrics', [])
Expand Down Expand Up @@ -50,7 +50,7 @@ def _parse_config(self):
config.update(self.instance)
self.scraper_configs.append(config)

def get_default_config(self):
def get_default_metrics(self):
metrics = []
for dm in DEFAULT_METRICS:
metrics.append(dm)
Expand Down