Skip to content

[tracer] Fix potential crash at shutdown - #9191

Open
gleocadie wants to merge 3 commits into
masterfrom
gleocadie/fix-tracer-shutdown-crash-for-jit
Open

[tracer] Fix potential crash at shutdown#9191
gleocadie wants to merge 3 commits into
masterfrom
gleocadie/fix-tracer-shutdown-crash-for-jit

Conversation

@gleocadie

@gleocadie gleocadie commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Summary of changes

Fix calls into CLR for an unloaded module.

Reason for change

At shutdown, ReJit can call into the CLR for an unloaded module and this leads to a crash.

Error UnhandledException: Process was terminated due to an unknown unhandled exception of type EXCEPTION_ACCESS_VIOLATION (0xC0000005)
#0   0x00007ffb548beb4f PEFile::GetScopeName(char const**)
#1   0x00007ffb54a31d0a ProfToEEInterfaceImpl::GetModuleInfo2(uint64_t, unsigned char const**, unsigned long, unsigned long*, unsigned short* const, uint64_t*, unsigned long*)
#2   0x00007ffb2b56d2ff trace::GetModuleInfo(ICorProfilerInfo4*, unsigned long long const&) (c:\mnt\tracer\src\Datadog.Tracer.Native\clr_helpers.cpp:213)
#3   0x00007ffb2b58c3f6 trace::RejitPreprocessor<trace::IntegrationDefinition>::PreprocessRejitRequests(std::vector<unsigned __int64,std::allocator<unsigned __int64> > const&, std::vector<trace::IntegrationDefinition,std::allocator<trace::IntegrationDefinition> > const&, std::vector<trace::MethodIdentifier,std::allocator<trace::MethodIdentifier> >&) (c:\mnt\tracer\src\Datadog.Tracer.Native\rejit_preprocessor.cpp:565)
#4   0x0000000000000000 trace::RejitPreprocessor<trace::IntegrationDefinition>::RequestRejitForLoadedModules(std::vector<unsigned __int64,std::allocator<unsigned __int64> > const&, std::vector<trace::IntegrationDefinition,std::allocator<trace::IntegrationDefinition> > const&, bool) (c:\mnt\tracer\src\Datadog.Tracer.Native\rejit_preprocessor.cpp:436)
#5   0x0000000000000000 trace::RejitPreprocessor<trace::IntegrationDefinition>::EnqueueRequestRejitForLoadedModules::__l2::<lambda_1>::operator()() (c:\mnt\tracer\src\Datadog.Tracer.Native\rejit_preprocessor.cpp:535)
#6   0x0000000000000000 std::invoke(trace::RejitPreprocessor<trace::IntegrationDefinition>::EnqueueRequestRejitForLoadedModules::__l2::<lambda_1>&) (c:\devtools\vstudio\VC\Tools\MSVC\14.44.35207\include\type_traits:1670)
#7   0x00007ffb2b59349a std::_Func_impl_no_alloc<`trace::RejitPreprocessor<trace::IntegrationDefinition>::EnqueueRequestRejitForLoadedModules'::`2'::<lambda_1>,void>::_Do_call() (c:\devtools\vstudio\VC\Tools\MSVC\14.44.35207\include\functional:880)
#8   0x00007ffb2b594ac5 trace::RejitWorkOffloader::EnqueueThreadLoop(trace::RejitWorkOffloader*) (c:\mnt\tracer\src\Datadog.Tracer.Native\rejit_work_offloader.cpp:87)
#9   0x00007ffb2b594c1e std::thread::_Invoke<std::tuple<`trace::RejitWorkOffloader::RejitWorkOffloader'::`1'::<lambda_2_> >,0>(void*) (c:\devtools\vstudio\VC\Tools\MSVC\14.44.35207\include\thread:61)
#10  0x00007ffb2b61d1f4 thread_start<unsigned int (__cdecl*)(void *),1>(void* const) (minkernel\crts\ucrt\src\appcrt\startup\thread.cpp:97)
#11  0x00007ffb7c6be957 BaseThreadInitThunk
#12  0x00007ffb7dd6ad6c RtlUserThreadStart

Implementation details

The idea is to handle modules clean up while we have in-flight ReJIT requests.

  • Add notification mechanism to prepare handlers: for ReJIT handler, we remove reused module ID.
  • Record when a request is in-flight. Use RAII to notify when a request ended.
  • Record unloaded modules.
  • When ReJIT requests are handled, check if the associated module is unloaded or not. If it's the case, just bail to avoid crashing.

Test coverage

Other details

I reproduced the crash locally by adding a sleep in the EnqueueThreadLoop infinite-loop to simulate thread descheduling, processing slowness... and this PR actually fixes the crash.

@gleocadie
gleocadie requested review from a team as code owners September 7, 2026 12:45
@gleocadie
gleocadie requested review from zacharycmontoya and removed request for a team September 7, 2026 12:45

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d708ef0ffa

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread tracer/src/Datadog.Tracer.Native/rejit_preprocessor.cpp
Comment thread tracer/src/Datadog.Tracer.Native/rejit_preprocessor.cpp Outdated
@dd-trace-dotnet-ci-bot

dd-trace-dotnet-ci-bot Bot commented Sep 7, 2026

Copy link
Copy Markdown

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (9191) and master.

✅ No regressions detected

📄 View the full report (charts + all metrics) →

@pr-commenter

pr-commenter Bot commented Sep 7, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-09-07 20:07:35

Comparing candidate commit 52f85a0 in PR branch gleocadie/fix-tracer-shutdown-crash-for-jit with baseline commit 018da89 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 0 performance regressions! Performance is the same for 72 metrics, 0 unstable metrics, 66 known flaky benchmarks, 60 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1

  • 🟥 throughput [-14184.465op/s; -12221.030op/s] or [-6.106%; -5.260%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • 🟥 throughput [-6618.045op/s; -6146.482op/s] or [-7.847%; -7.288%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • 🟥 throughput [-9432.194op/s; -8033.437op/s] or [-9.590%; -8.168%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 allocated_mem [+1.541KB; +1.541KB] or [+46.817%; +46.831%]
  • 🟥 execution_time [+308.702ms; +311.347ms] or [+153.189%; +154.501%]
  • 🟥 throughput [-57.401op/s; -53.245op/s] or [-10.327%; -9.580%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 allocated_mem [+1.013KB; +1.013KB] or [+37.563%; +37.575%]
  • 🟥 execution_time [+374.671ms; +376.711ms] or [+296.013%; +297.625%]
  • 🟩 throughput [+68.137op/s; +71.532op/s] or [+8.984%; +9.431%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 allocated_mem [+1.090KB; +1.090KB] or [+40.417%; +40.429%]
  • 🟥 execution_time [+396.793ms; +400.275ms] or [+351.147%; +354.228%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+4.725KB; +4.726KB] or [+99.482%; +99.497%]
  • 🟥 throughput [-60589.090op/s; -60186.138op/s] or [-47.141%; -46.828%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+3.848KB; +3.848KB] or [+81.379%; +81.391%]
  • 🟩 execution_time [-16.540ms; -12.359ms] or [-7.725%; -5.772%]
  • 🟥 throughput [-60531.817op/s; -57764.997op/s] or [-44.185%; -42.165%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+4.576KB; +4.576KB] or [+98.954%; +98.966%]
  • 🟥 throughput [-49435.205op/s; -47187.275op/s] or [-44.695%; -42.663%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.348KB; +1.348KB] or [+109.063%; +109.078%]
  • 🟥 throughput [-298411.910op/s; -295401.203op/s] or [-30.469%; -30.162%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+511 bytes; +512 bytes] or [+41.822%; +41.834%]
  • 🟩 execution_time [-26.689ms; -21.774ms] or [-11.902%; -9.710%]
  • 🟥 throughput [-126404.448op/s; -103257.577op/s] or [-13.504%; -11.031%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.312KB; +1.312KB] or [+108.600%; +108.616%]
  • 🟥 throughput [-166792.386op/s; -150474.364op/s] or [-23.965%; -21.620%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472

  • 🟥 allocated_mem [+3.378KB; +3.378KB] or [+89.003%; +89.017%]
  • 🟥 throughput [-72468.480op/s; -71706.989op/s] or [-48.770%; -48.258%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • 🟥 allocated_mem [+3.336KB; +3.336KB] or [+88.150%; +88.161%]
  • 🟥 throughput [-73358.098op/s; -70474.383op/s] or [-46.677%; -44.842%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+3.264KB; +3.264KB] or [+88.493%; +88.506%]
  • 🟥 throughput [-56398.937op/s; -53774.912op/s] or [-44.929%; -42.839%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 throughput [+338603.615op/s; +359679.506op/s] or [+11.290%; +11.993%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟩 execution_time [-18.867ms; -14.536ms] or [-8.697%; -6.701%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • 🟩 allocated_mem [-13.759KB; -13.756KB] or [-42.324%; -42.316%]
  • 🟥 execution_time [+301.497ms; +302.250ms] or [+150.648%; +151.024%]
  • 🟩 throughput [+995.300op/s; +1014.549op/s] or [+10.993%; +11.206%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • 🟩 allocated_mem [-13.722KB; -13.718KB] or [-42.341%; -42.329%]
  • 🟥 execution_time [+300.301ms; +303.537ms] or [+151.442%; +153.074%]
  • 🟩 throughput [+2374.714op/s; +2593.241op/s] or [+18.163%; +19.834%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • 🟩 allocated_mem [-13.722KB; -13.718KB] or [-42.341%; -42.329%]
  • 🟥 execution_time [+300.395ms; +302.820ms] or [+151.316%; +152.537%]
  • 🟩 throughput [+1761.743op/s; +1887.560op/s] or [+17.009%; +18.223%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • 🟥 execution_time [+295.890ms; +296.644ms] or [+145.330%; +145.700%]
  • 🟩 throughput [+580.738op/s; +594.188op/s] or [+15.396%; +15.752%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+298.134ms; +299.062ms] or [+145.747%; +146.200%]
  • 🟩 throughput [+2630.387op/s; +2670.274op/s] or [+38.215%; +38.794%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+300.072ms; +300.709ms] or [+149.976%; +150.294%]
  • 🟩 throughput [+1454.085op/s; +1475.319op/s] or [+28.862%; +29.284%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472

  • 🟩 execution_time [-145.326µs; -140.674µs] or [-29.837%; -28.882%]
  • 🟩 throughput [+838.142op/s; +870.462op/s] or [+40.821%; +42.395%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0

  • 🟩 execution_time [-138.271µs; -111.588µs] or [-31.713%; -25.593%]
  • 🟩 throughput [+853.887op/s; +976.663op/s] or [+37.124%; +42.461%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1

  • 🟩 execution_time [-142.684µs; -120.504µs] or [-30.571%; -25.818%]
  • 🟩 throughput [+775.555op/s; +861.607op/s] or [+35.801%; +39.773%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472

  • 🟩 execution_time [-130.577µs; -126.627µs] or [-35.255%; -34.188%]
  • 🟩 throughput [+1415.352op/s; +1458.486op/s] or [+52.418%; +54.016%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟩 execution_time [-102.978µs; -79.389µs] or [-32.875%; -25.345%]
  • 🟩 throughput [+1195.796op/s; +1397.342op/s] or [+37.276%; +43.559%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1

  • 🟩 execution_time [-137.046µs; -114.662µs] or [-37.490%; -31.367%]
  • 🟩 throughput [+1317.779op/s; +1454.531op/s] or [+47.290%; +52.197%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • 🟥 execution_time [+299.767ms; +300.529ms] or [+149.614%; +149.995%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • 🟥 execution_time [+415.134ms; +422.485ms] or [+451.061%; +459.047%]
  • 🟩 throughput [+755.025op/s; +934.979op/s] or [+6.204%; +7.683%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • unstable execution_time [+296.214ms; +350.392ms] or [+224.912%; +266.049%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 allocated_mem [+2.834KB; +2.839KB] or [+5.035%; +5.044%]
  • unstable execution_time [+323.031ms; +392.697ms] or [+148.527%; +180.558%]
  • 🟥 throughput [-576.873op/s; -517.171op/s] or [-52.270%; -46.861%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • unstable execution_time [+199.589ms; +332.819ms] or [+85.056%; +141.833%]
  • 🟥 throughput [-672.078op/s; -588.651op/s] or [-44.828%; -39.263%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+336.280ms; +345.033ms] or [+201.134%; +206.370%]
  • 🟥 throughput [-382.547op/s; -346.345op/s] or [-26.636%; -24.116%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • 🟩 execution_time [-184.095µs; -118.390µs] or [-9.326%; -5.997%]
  • 🟩 throughput [+35.017op/s; +53.209op/s] or [+6.913%; +10.504%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1

  • unstable throughput [+15.078op/s; +57.031op/s] or [+5.946%; +22.489%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • 🟥 execution_time [+302.279ms; +303.833ms] or [+152.222%; +153.005%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • 🟥 execution_time [+300.900ms; +303.152ms] or [+150.781%; +151.910%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • 🟥 execution_time [+301.556ms; +305.228ms] or [+151.489%; +153.333%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • 🟥 execution_time [+300.377ms; +302.018ms] or [+150.839%; +151.663%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • 🟥 execution_time [+297.477ms; +299.313ms] or [+147.089%; +147.997%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟥 execution_time [+302.097ms; +306.191ms] or [+153.116%; +155.191%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟥 execution_time [+302.438ms; +305.281ms] or [+151.797%; +153.224%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • 🟥 execution_time [+298.342ms; +300.804ms] or [+148.696%; +149.923%]
  • 🟩 throughput [+42338.393op/s; +46345.052op/s] or [+8.407%; +9.203%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • 🟥 execution_time [+299.835ms; +302.573ms] or [+149.165%; +150.528%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472

  • 🟥 throughput [-15310.970op/s; -13992.680op/s] or [-6.157%; -5.627%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • 🟩 execution_time [-15.756ms; -12.027ms] or [-7.327%; -5.593%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472

  • unstable execution_time [+3.599µs; +49.016µs] or [+0.889%; +12.107%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-18.220KB; -18.197KB] or [-6.646%; -6.638%]
  • unstable execution_time [-42.346µs; +12.457µs] or [-8.369%; +2.462%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • 🟩 allocated_mem [-15.254KB; -15.236KB] or [-5.561%; -5.554%]
  • unstable execution_time [-71.045µs; -12.088µs] or [-12.312%; -2.095%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • unstable execution_time [+7.402µs; +12.213µs] or [+17.496%; +28.867%]
  • 🟥 throughput [-5319.208op/s; -3389.284op/s] or [-22.392%; -14.268%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • unstable execution_time [-14.562µs; -6.468µs] or [-22.592%; -10.035%]
  • unstable throughput [+1705.490op/s; +3473.411op/s] or [+10.464%; +21.311%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • 🟥 execution_time [+301.800ms; +303.670ms] or [+152.546%; +153.492%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+304.262ms; +307.604ms] or [+154.868%; +156.569%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+300.339ms; +304.084ms] or [+150.357%; +152.231%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • 🟥 execution_time [+299.539ms; +301.713ms] or [+149.293%; +150.377%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+301.405ms; +302.853ms] or [+151.351%; +152.078%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+303.340ms; +305.659ms] or [+153.835%; +155.010%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • 🟥 execution_time [+300.074ms; +301.175ms] or [+149.678%; +150.228%]
  • 🟩 throughput [+60996075.114op/s; +61411291.108op/s] or [+44.421%; +44.724%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • unstable execution_time [+339.711ms; +395.621ms] or [+422.491%; +492.025%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 execution_time [+298.961ms; +299.949ms] or [+149.115%; +149.608%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

  • 🟩 throughput [+53449.904op/s; +72708.780op/s] or [+6.187%; +8.416%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • 🟩 throughput [+68982.268op/s; +79495.082op/s] or [+6.851%; +7.895%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟩 throughput [+37065.422op/s; +43598.222op/s] or [+6.730%; +7.917%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • 🟩 throughput [+67390.960op/s; +86709.118op/s] or [+7.529%; +9.688%]

Known flaky benchmarks without significant changes:

  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

@gleocadie
gleocadie requested a review from a team as a code owner September 7, 2026 19:17
@gleocadie
gleocadie force-pushed the gleocadie/fix-tracer-shutdown-crash-for-jit branch from 52f85a0 to c11c981 Compare September 9, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants