[dropwizard] Add a Check for the popular Java Dropwizard framework - #3058
[dropwizard] Add a Check for the popular Java Dropwizard framework#3058cberry777 wants to merge 5 commits into
Conversation
|
This is failing because of a flaky test -- as far as I can tell |
|
@masci - any idea if this PR will get considered? |
|
Hi @cberry777 , |
|
@masci -- thanks very much. I have another Check y'all need -- for Jolokia based metrics Thanks again! |
|
Hi @cberry777, Thanks again for your contribution, always very much appreciated. We're currently transitioning our checks to a new SDK-based model for the agent. An unfortunate side-effect is that we have to impose a freeze on the dd-agent repo. The SDK consists of two repositories https://github.com/DataDog/integrations-core and https://github.com/DataDog/integrations-extras, where all of our checks will reside. This PR would belong in the core/extras repository. Would you be so kind as to re-open the PR there? We have facilitated some tools to help you with the SDK development that should help you get up and running in no time: sdk guide datadog sdk gem. We are very sorry for the inconvenience caused. Thank you for your patience as we make this transition! |
|
@cberry777, @masci and I, we've taken the liberty of opening a PR here to help you transition to the SDK DataDog/integrations-extras#36 We created a patch with your work and dropped it that PR. Please feel free to continue your work there. 🙇 |
What does this PR do?
Adds a new DropwizardCheck.
A DataDog check for the popular Java Dropwizard framework.
Motivation
Dropwizard is a widely popular Java framework for creating microservices.
(For further details, see http://metrics.dropwizard.io/3.1.0/)
The Java world really needs a first class check in DataDog for Dropwizard services.
DropwizardCheck calls the standard Dropwizard stats URL: http://localhost:8081/metrics -- which yields up a JSON response consisting of the all metrics in it's MetricRegistry at that time. DropwizardCheck reads this response, parses it, and creates the corresponding DataDog metrics.
Testing Guidelines
A Testcase is provided here: tests/checks/mock/test_dropwizard.py
It contains 5 tests.
Additional Notes
Please see the DropwizardCheck (checks.d/dropwizard.py) for quite a bit of documentation.
NOTE: A form of this code has been running in Production for many months at my employer.
And we've decided to make it available to all...