[CONTP-1596]Improve GKE Autopilot support#3013
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d80ce13ee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3013 +/- ##
==========================================
+ Coverage 40.77% 41.23% +0.46%
==========================================
Files 332 332
Lines 28204 28299 +95
==========================================
+ Hits 11500 11669 +169
+ Misses 15929 15843 -86
- Partials 775 787 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
7d80ce1 to
5f79f93
Compare
This comment has been minimized.
This comment has been minimized.
5f79f93 to
1e614a8
Compare
1e614a8 to
7cf3137
Compare
What does this PR do?
Updates GKE Autopilot support for DatadogAgent reconciliation and the GKE WorkloadAllowlist synchronizer.
Commit breakdown:
a32ab68
v1.0.3.experimental.agent.datadoghq.com/autopilot-allowlist-versionoverride.AllowlistSynchronizerwith operator ownership labels, including the DatadogAgentapp.kubernetes.io/part-ofvalue.AllowlistSynchronizerwith server-side apply so existingdatadog-synchronizerobjects are updated when the desired allowlist path or labels change.allowlistsynchronizers.auto.gke.iofor server-side apply.1246fa3
DD_KUBELET_USE_API_SERVER=truefor Autopilot.get/listRBAC when API-server pod discovery is required.b8ff129
7ae8486
363ea70
7cf3137
Motivation
The existing Autopilot overrides were out of date with current GKE Autopilot allowlist behavior and left several generated pod specs with resources, mounts, or discovery settings that are not valid on Autopilot.
This also makes the WorkloadAllowlist version explicit and overrideable, so future allowlist bumps do not require changing the synchronizer logic.
Additional Notes
mainwith the Autopilot work grouped into reviewable commits. Two unrelated unused helper functions from the original branch history were intentionally left out ofcontroller_v2_test.go.Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Verified on
v1.35.3-gke.1737000Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel