Skip to content

Support oomKill, tcpQueueLength features on GKE COS via provider annotation#3011

Draft
levan-m wants to merge 1 commit into
levan-m/providers-ddaifrom
levan-m/cos-provider
Draft

Support oomKill, tcpQueueLength features on GKE COS via provider annotation#3011
levan-m wants to merge 1 commit into
levan-m/providers-ddaifrom
levan-m/cos-provider

Conversation

@levan-m
Copy link
Copy Markdown
Collaborator

@levan-m levan-m commented May 13, 2026

What does this PR do?

Support oomKill, tcpQueueLength GKE COS provider via annotation (no introspection).

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

  1. Provision GKE cluster with COS nodes
  2. Install Operator
  3. Apply DDA with two features enabled.
apiVersion: datadoghq.com/v2alpha1
kind: DatadogAgent
metadata:
  name: datadog-agent
spec:
  global:
    credentials:
      apiSecret:
        secretName: datadog-secret
        keyName: api-key
      appSecret:
        secretName: datadog-secret
        keyName: app-key
    clusterName: cos-test
  features:
    oomKill:
      enabled: true
    tcpQueueLength:
      enabled: true
  1. DS is create but pod creation is error due to failed to generate spec: failed to mkdir "/usr/src": mkdir /usr/src: read-only file system
  2. Add annotation to DDA and reapply
  annotations:
    datadoghq.com/provider: gke-cos
  1. Pod starts successfully.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

@datadog-datadog-prod-us1-2

This comment has been minimized.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 13, 2026

Codecov Report

❌ Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.64%. Comparing base (97d838e) to head (23dbd5f).

Files with missing lines Patch % Lines
...controller/datadogagent/feature/oomkill/feature.go 0.00% 5 Missing ⚠️
...ler/datadogagent/feature/tcpqueuelength/feature.go 0.00% 5 Missing ⚠️
internal/controller/datadogagent/profile.go 50.00% 1 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (14.28%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           levan-m/providers-ddai    #3011      +/-   ##
==========================================================
- Coverage                   40.65%   40.64%   -0.02%     
==========================================================
  Files                         333      333              
  Lines                       28272    28286      +14     
==========================================================
+ Hits                        11495    11497       +2     
- Misses                      16002    16013      +11     
- Partials                      775      776       +1     
Flag Coverage Δ
unittests 40.64% <14.28%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/kubernetes/provider.go 86.36% <ø> (ø)
internal/controller/datadogagent/profile.go 72.00% <50.00%> (-0.61%) ⬇️
...controller/datadogagent/feature/oomkill/feature.go 73.21% <0.00%> (-7.18%) ⬇️
...ler/datadogagent/feature/tcpqueuelength/feature.go 73.43% <0.00%> (-6.23%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97d838e...23dbd5f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants