Skip to content

Provider capabilities basic framework and eks.ec2.useHostnameFromFile support#3009

Open
levan-m wants to merge 2 commits into
levan-m/drop-feature-providerfrom
levan-m/providers-ddai
Open

Provider capabilities basic framework and eks.ec2.useHostnameFromFile support#3009
levan-m wants to merge 2 commits into
levan-m/drop-feature-providerfrom
levan-m/providers-ddai

Conversation

@levan-m
Copy link
Copy Markdown
Collaborator

@levan-m levan-m commented May 12, 2026

CONTP-1570

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

@levan-m levan-m added this to the v1.28.0 milestone May 12, 2026
@levan-m levan-m added the enhancement New feature or request label May 12, 2026
@levan-m levan-m changed the title Levan m/providers ddai Provider capabilities basic framework and eks.ec2.useHostnameFromFile support May 12, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 12, 2026

Codecov Report

❌ Patch coverage is 0% with 75 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.65%. Comparing base (ad3bec8) to head (97d838e).

Files with missing lines Patch % Lines
...datadogagent/providercaps/provider_capabilities.go 0.00% 66 Missing ⚠️
...datadogagentinternal/controller_reconcile_agent.go 0.00% 7 Missing ⚠️
...er/datadogagentinternal/controller_reconcile_v2.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                        Coverage Diff                        @@
##           levan-m/drop-feature-provider    #3009      +/-   ##
=================================================================
- Coverage                          40.76%   40.65%   -0.11%     
=================================================================
  Files                                332      333       +1     
  Lines                              28199    28272      +73     
=================================================================
  Hits                               11495    11495              
- Misses                             15929    16002      +73     
  Partials                             775      775              
Flag Coverage Δ
unittests 40.65% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/controller/datadogagent/feature/types.go 22.10% <ø> (ø)
pkg/kubernetes/provider.go 86.36% <ø> (ø)
...er/datadogagentinternal/controller_reconcile_v2.go 0.00% <0.00%> (ø)
...datadogagentinternal/controller_reconcile_agent.go 4.16% <0.00%> (-0.22%) ⬇️
...datadogagent/providercaps/provider_capabilities.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad3bec8...97d838e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@datadog-official

This comment has been minimized.

@levan-m levan-m marked this pull request as ready for review May 13, 2026 00:50
@levan-m levan-m requested a review from a team as a code owner May 13, 2026 00:50
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 97d838ec57

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +72 to +76
Containers: []apicommon.AgentContainerName{
apicommon.CoreAgentContainerName,
apicommon.TraceAgentContainerName,
apicommon.ProcessAgentContainerName,
apicommon.SystemProbeContainerName,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Mount cloud-init file in single-agent node container

The EKS useHostnameFromFile capability adds DD_HOSTNAME_FILE to all agent containers, but this mount target list excludes apicommon.UnprivilegedSingleAgentContainerName. In single-container strategy, only unprivileged-single-agent runs, so the env var points to /var/lib/cloud/data/instance-id without mounting that host file, which breaks the advertised provider behavior for this mode. Add the single-agent container name to this mount list (or apply the mount to all agent containers) so the file exists where the env var points.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants