Provider capabilities basic framework and eks.ec2.useHostnameFromFile support#3009
Provider capabilities basic framework and eks.ec2.useHostnameFromFile support#3009levan-m wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## levan-m/drop-feature-provider #3009 +/- ##
=================================================================
- Coverage 40.76% 40.65% -0.11%
=================================================================
Files 332 333 +1
Lines 28199 28272 +73
=================================================================
Hits 11495 11495
- Misses 15929 16002 +73
Partials 775 775
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97d838ec57
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| Containers: []apicommon.AgentContainerName{ | ||
| apicommon.CoreAgentContainerName, | ||
| apicommon.TraceAgentContainerName, | ||
| apicommon.ProcessAgentContainerName, | ||
| apicommon.SystemProbeContainerName, |
There was a problem hiding this comment.
Mount cloud-init file in single-agent node container
The EKS useHostnameFromFile capability adds DD_HOSTNAME_FILE to all agent containers, but this mount target list excludes apicommon.UnprivilegedSingleAgentContainerName. In single-container strategy, only unprivileged-single-agent runs, so the env var points to /var/lib/cloud/data/instance-id without mounting that host file, which breaks the advertised provider behavior for this mode. Add the single-agent container name to this mount list (or apply the mount to all agent containers) so the file exists where the env var points.
Useful? React with 👍 / 👎.
CONTP-1570
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel