Skip to content

[CONTP-1639] Refactor CRD metadata collection to use informer #2979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhuminyi merged 4 commits into from
May 18, 2026
Merged

[CONTP-1639] Refactor CRD metadata collection to use informer #2979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ab680e
feat(metadata): add shared InformerWorkQueue engine
zhuminyi May 6, 2026
88fcc25
refactor(metadata): migrate HelmMetadataForwarder to InformerWorkQueue
zhuminyi May 6, 2026
45b81c9
feat(metadata): make CRDMetadataForwarder event-driven via InformerWo…
zhuminyi May 6, 2026
482c271
Merge branch 'main' into minyi/contp-1639-crd-metadata-informer
zhuminyi May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions cmd/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,12 +401,16 @@ func run(opts *options) error {
return setupErrorf(setupLog, err, "Unable to setup Helm metadata forwarder")
}

// Start ticker-based metadata forwarders after leader election
// Register CRD metadata forwarder as a manager Runnable
if err = setupAndStartCRDMetadataForwarder(metadataLog, mgr, versionInfo.String(), opts, options.CredsManager); err != nil {
return setupErrorf(setupLog, err, "Unable to setup CRD metadata forwarder")
}

// Operator metadata forwarder still uses a poll loop; start after leader election.
go func() {
<-mgr.Elected()
setupLog.Info("Starting metadata forwarders")
setupLog.Info("Starting operator metadata forwarder")
setupAndStartOperatorMetadataForwarder(metadataLog, mgr.GetClient(), versionInfo.String(), opts, options.CredsManager)
setupAndStartCRDMetadataForwarder(metadataLog, mgr.GetClient(), versionInfo.String(), opts, options.CredsManager)
}()

// +kubebuilder:scaffold:builder
Expand Down Expand Up @@ -627,10 +631,10 @@ func setupAndStartOperatorMetadataForwarder(logger logr.Logger, client client.Re
omf.Start()
}

func setupAndStartCRDMetadataForwarder(logger logr.Logger, client client.Reader, kubernetesVersion string, options *options, credsManager *config.CredentialManager) {
func setupAndStartCRDMetadataForwarder(logger logr.Logger, mgr manager.Manager, kubernetesVersion string, options *options, credsManager *config.CredentialManager) error {
cmf := metadata.NewCRDMetadataForwarder(
logger,
client,
mgr,
kubernetesVersion,
version.GetVersion(),
credsManager,
Expand All @@ -641,7 +645,7 @@ func setupAndStartCRDMetadataForwarder(logger logr.Logger, client client.Reader,
DatadogAgentProfileEnabled: options.datadogAgentProfileEnabled,
},
)
cmf.Start()
return mgr.Add(cmf)
}

func setupAndStartHelmMetadataForwarder(logger logr.Logger, mgr manager.Manager, client client.Reader, kubernetesVersion string, credsManager *config.CredentialManager) error {
Expand Down
Loading
Loading