-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: add autodiscovery for kata containers integration #49689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TheRayquaza
wants to merge
2
commits into
main
Choose a base branch
from
mateo.lelong/kata-autodiscovery
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| ad_identifiers: | ||
| - _kata_containers | ||
| init_config: | ||
| instances: | ||
| - | ||
| ## @param sandbox_storage_paths - list of strings - optional - default: ["/run/vc/sbs", "/run/kata"] | ||
| ## Directories to scan for Kata shim sockets. When running the Agent in a container, | ||
| ## host paths are typically mounted under /host — both variants are listed here so the | ||
| ## check works without manual configuration in either deployment mode. | ||
| # | ||
| sandbox_storage_paths: | ||
| - /host/run/vc/sbs | ||
| - /host/run/kata | ||
|
|
||
| ## @param tags - list of strings following the pattern: "key:value" - optional | ||
| ## List of tags to attach to every metric, event, and service check emitted by this integration. | ||
| ## | ||
| ## Learn more about tagging: https://docs.datadoghq.com/tagging/ | ||
| # | ||
| # tags: | ||
| # - <KEY_1>:<VALUE_1> | ||
| # - <KEY_2>:<VALUE_2> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
releasenotes/notes/kata-containers-autodiscovery-f654d29fe08482c7.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| features: | ||
| - | | ||
| Add automatic discovery of Kata Containers environments. The Agent now detects | ||
| the presence of Kata sandbox paths (``/host/run/vc/sbs``, ``/host/run/kata``) at startup | ||
| and automatically enables the ``kata_containers`` check without manual | ||
| configuration. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See conversation in slack: https://dd.slack.com/archives/C4TQDFK1P/p1776958386678999?thread_ts=1776947531.092389&cid=C4TQDFK1P
I don't know that the inclusion of this file should be part of this PR, but this file specifically should not be added to this repo without a corresponding entry in https://github.com/DataDog/integrations-core (or, at least, a corresponding PR in that repo)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, I added a draft PR for the kata container integration:
DataDog/integrations-core#23465