Skip to content

Adding option to ignore Dockercloud containers - #1218

Merged
CharlyF merged 1 commit into
masterfrom
charly/dockercloud_ignore_containers
Feb 9, 2018
Merged

Adding option to ignore Dockercloud containers#1218
CharlyF merged 1 commit into
masterfrom
charly/dockercloud_ignore_containers

Conversation

@CharlyF

@CharlyF CharlyF commented Feb 9, 2018

Copy link
Copy Markdown
Contributor

What does this PR do?

Adding documentation about excluding dockercloud containers.

Motivation

Community request.

Testing Guidelines

No need.

Mirror of DataDog/dd-agent#3666

@CharlyF
CharlyF requested a review from a team February 9, 2018 01:27
@CharlyF
CharlyF requested review from a team as code owners February 9, 2018 01:27

@hkaj hkaj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's discuss if we can avoid adding yet another flag for this

Comment thread pkg/config/config_template.yaml Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you're missing image: in the last two ones

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ thanks for the 👀

@CharlyF
CharlyF force-pushed the charly/dockercloud_ignore_containers branch 3 times, most recently from 2ea258e to 5106776 Compare February 9, 2018 18:41
@CharlyF
CharlyF force-pushed the charly/dockercloud_ignore_containers branch from 5106776 to 91d198d Compare February 9, 2018 18:47

@mfpierre mfpierre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳 ☁️

@CharlyF
CharlyF merged commit 23d4fdb into master Feb 9, 2018
@CharlyF
CharlyF deleted the charly/dockercloud_ignore_containers branch February 9, 2018 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants