Accept any string for auth.site, validate at startup#387
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoMay 22, 2026
Conversation
Loosen the user-facing AuthOptions.site type from the Site union to plain string so customers can pass values from env vars or config files without TypeScript friction. Validation in validateOptions already rejects unknown sites at startup, so this is a type-only change. AuthOptionsWithDefaults still narrows site back to Site for downstream consumers (RUM SDK, Metrics URLs, etc). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
oliver/accept-any-string-for-auth.site-validate-at-startup
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AuthOptions.sitetype from theSiteunion to plainstring, so callers can pass values sourced from env vars or dynamic config without TypeScript friction.validateOptionsalready validatesauth.siteagainst theSITESlist at startup (viaresolveSite) and throws an aggregated error for unsupported sites.AuthOptionsWithDefaultsstill narrowssiteback toSite(viaOmit<AuthOptions, 'site'> & { site: Site }), so downstream consumers (RUM SDK config, Metrics URL templates, Error Tracking, Apps) keep the constrained type.Test plan
yarn typecheck:allyarn test:unit packages/factory(coversvalidateOptions)yarn cli integrity🤖 Generated with Claude Opus 4.7