[APPS] Add published artifact loadability test#383
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoMay 21, 2026
Merged
Conversation
sdkennedy2
changed the title
Collaborator
Author
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 58b47cb | Docs | Datadog PR Page | Give us feedback! |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
sdkennedy2
force-pushed
the
sdkennedy2/add-published-artifact-loadability-test
branch
2 times, most recently
from
0ecb93f to
9e42eec
Compare
sdkennedy2
force-pushed
the
sdkennedy2/add-published-artifact-loadability-test
branch
from
9e42eec to
58b47cb
Compare
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
sdkennedy2/add-published-artifact-loadability-test
branch
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The published
@datadog/vite-pluginESM artifact was recently corrupted by a build-time shim insertion issue. The package metadata looked valid, butdist/src/index.mjscould not be parsed or imported by Vite config loading. We need CI coverage that validates the generated publish artifacts, not only the TypeScript source and bundler behavior.Changes
Adds an artifact-level unit test for each published Datadog bundler plugin. The test reads
publishConfig.exports[\".\"], confirms the ESM, CJS, and type entries point at existing built files, syntax-checks the JavaScript entries with Node, and verifies both ESM import and CJS require work from a child process.The test intentionally validates
publishConfig.exportsinstead of local developmentexports, because workspace/local-link exports may point at TypeScript source while npm publish metadata points at generateddistfiles.Also allows the local Node warning emitted when
NO_COLORandFORCE_COLORare both present so the focused unit test remains stable in shells withNO_COLORset.QA Instructions
No manual QA needed; this is CI coverage for generated package artifacts.
Blast Radius
Low. This only changes test coverage and a Jest warning allowlist. Runtime package code is unchanged.
Documentation