Skip to content

Default args and locals params in debugger snapshot hooks #4609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 1 commit into from
May 20, 2026
Merged

Default args and locals params in debugger snapshot hooks #4609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/debugger/src/domain/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export function resetDebuggerTransport(): void {
* @param self - The 'this' context
* @param args - Function arguments
*/
export function onEntry(probes: InitializedProbe[], self: any, args: Record<string, any>): void {
export function onEntry(probes: InitializedProbe[], self: any, args: Record<string, any> = {}): void {
const start = performance.now()
const captureCtx: CaptureContext = { deadline: start + SNAPSHOT_TIMEOUT_MS, timedOut: false }

Expand Down Expand Up @@ -125,8 +125,8 @@ export function onReturn(
probes: InitializedProbe[],
value: any,
self: any,
args: Record<string, any>,
locals: Record<string, any>
args: Record<string, any> = {},
locals: Record<string, any> = {}
): any {
const end = performance.now()
const captureCtx: CaptureContext = { deadline: performance.now() + SNAPSHOT_TIMEOUT_MS, timedOut: false }
Expand Down Expand Up @@ -195,7 +195,7 @@ export function onReturn(
* @param self - The 'this' context
* @param args - Function arguments
*/
export function onThrow(probes: InitializedProbe[], error: Error, self: any, args: Record<string, any>): void {
export function onThrow(probes: InitializedProbe[], error: Error, self: any, args: Record<string, any> = {}): void {
const end = performance.now()
const captureCtx: CaptureContext = { deadline: performance.now() + SNAPSHOT_TIMEOUT_MS, timedOut: false }

Expand Down
Loading