Obsolete the never-implemented type-handler pair as a warning, not an error - #209
Merged
Conversation
… error Both types have always been no-ops, so nothing depends on their behaviour - but code that names them does compile today, and an error breaks that build on upgrade. A warning still says what to use instead, and gives people a release to move at their own pace before it hardens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeHandlerAttribute<TValue, THandler>andTypeHandler<T>were obsoleted as errors in #208. Softening to warnings for the first release that carries the replacement.Nothing depends on their behaviour — they have always been no-ops — but code that names them compiles today, and per the discussion on #173 people did write them. An error turns an upgrade into a build break; a warning still names the replacement (
[TypeHandler(typeof(V), typeof(H))]+IDbValueHandler<T>) and gives people a release to move before it hardens.One-word change, plus the message text. Suite green (366 net8.0), solution builds clean.