Input 등 요소 HelpText 및 Error 구조 개선#957
Merged
hyoseong1994 merged 10 commits intomainfrom Apr 22, 2026
Merged
Conversation
hyoseong1994
force-pushed
the
825-inputs-helptext
branch
2 times, most recently
from
27bcb85 to
6fe6498
Compare
hyoseong1994
force-pushed
the
825-inputs-helptext
branch
3 times, most recently
from
9f54930 to
8479849
Compare
hyoseong1994
force-pushed
the
825-inputs-helptext
branch
from
292708a to
fa6b918
Compare
DaleSeo
reviewed
Apr 16, 2026
hyoseong1994
force-pushed
the
825-inputs-helptext
branch
from
324dad3 to
52af4c9
Compare
hyoseong1994
force-pushed
the
825-inputs-helptext
branch
from
80c3423 to
e8243fe
Compare
hyoseong1994
force-pushed
the
825-inputs-helptext
branch
3 times, most recently
from
3341f6b to
be059a9
Compare
…lid and disabled states
…eving the password field
hyoseong1994
force-pushed
the
825-inputs-helptext
branch
from
031c168 to
92a0938
Compare
hyoseong1994
force-pushed
the
825-inputs-helptext
branch
from
92a0938 to
7273d06
Compare
DaleSeo
approved these changes
Apr 20, 2026
Member
DaleSeo
left a comment
DaleSeo
left a comment
There was a problem hiding this comment.
여러 컴포넌트를 작업하시느라 고생하셨습니다! 소소한 질문만 있습니다.
DaleSeo
approved these changes
Apr 20, 2026
SimYunSup
approved these changes
Apr 21, 2026
Member
SimYunSup
left a comment
SimYunSup
left a comment
There was a problem hiding this comment.
고생하셨습니다! 리뷰 부분은 적용하셔도 적용하지 않으셔도 좋습니다 :)
| .filter((s): s is string => Boolean(s)) | ||
| .join(" ") || undefined; | ||
|
|
||
| return { helperTextId, bottomText, showBottomText, ariaDescribedBy, isError }; |
Member
There was a problem hiding this comment.
return 값을 적용하기 좋게 React Aria 방식처럼 fieldProps와 helpTextProps로 나누어서 전달하고 사용할 때 spread 방식으로 전달하는 것은 어떨까요?
Contributor
Author
There was a problem hiding this comment.
리뷰 감사합니다! 해당 내용 반영하여 머지하도록하겠습니다
Contributor
|
보다보니 하나 발견한게 있어서요! 요 티켓과는 조금 무관한 것 같기는 한데..! |
Contributor
Author
아마 디자인 작업이 먼저 진행되고 개발작업이 누락된거같아요 수정작업이 크지않아서 처리했습니다 |
…lpTextProps for better integration in form components
hyoseong1994
force-pushed
the
825-inputs-helptext
branch
from
516fbb9 to
a290f16
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
테스팅
체크 리스트