Skip to content

Copilot/worktree 2026 04 04 t18 52 34 - #34

Closed
DaanV2 wants to merge 2 commits into
mainfrom
copilot/worktree-2026-04-04T18-52-34
Closed

DaanV2 wants to merge 2 commits into
mainfrom
copilot/worktree-2026-04-04T18-52-34

Conversation

@DaanV2

@DaanV2 DaanV2 commented Apr 4, 2026

Copy link
Copy Markdown
Owner

No description provided.

DaanV2 and others added 2 commits April 4, 2026 20:39
…se sql.js webview DB

- Add `AssemblyRow` interface and `processAssembly()` to `lineMaps.ts`:
  single loop over the assembly text builds both the `sourceToLines`
  cursor-sync map and the structured row data for the webview — eliminates
  the duplicate `asm.split("\n")` + double-iteration that existed before.
  `buildLineMaps` is kept (marked deprecated) so existing tests pass.

- Rewrite `webviewHtml.ts` as `getShellHtml(filename, sqlJsUri, sqlWasmUri)`:
  the webview HTML is set **once** (no more full-page replacement on every
  update). It loads sql.js (SQLite WASM), creates an in-memory `asm_lines`
  table, and listens for `{ type: 'rows', rows }` messages. On each message
  it replaces the DB contents and re-renders only the DOM — scroll position
  and search state are preserved across recompiles.

- Update `webview.ts`: constructor takes `extensionUri`, serves sql-wasm.js
  and sql-wasm.wasm from `resources/` via `localResourceRoots` +
  `asWebviewUri`. `update()` now calls `processAssembly` and posts a single
  `rows` message instead of replacing `panel.webview.html`.

- Propagate `extensionUri` through `DocumentTracker` → `AssemblyView`.

- Install `sql.js`; add `esbuild.js` step to keep `resources/sql-wasm.{js,wasm}`
  in sync with `node_modules/sql.js/dist/` on every build.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added dependencies Pull requests that update a dependency file release labels Apr 4, 2026
@DaanV2 DaanV2 closed this Apr 4, 2026
@DaanV2
DaanV2 deleted the copilot/worktree-2026-04-04T18-52-34 branch April 19, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant